Build ODBC statically on macOS #153

justing-bq · 2026-01-30T17:40:38Z

Can we add some blank lines for readability?

alinaliBQ · 2026-01-29T18:11:02Z

Without this change, we have failed run with c-ares::cares: https://github.com/Bit-Quill/arrow/actions/runs/21459770235/job/61809740997?pr=153#step:7:540

Fixes error:

CMake Error at cmake_modules/ThirdpartyToolchain.cmake:3032 (set_target_properties): set_target_properties can not be used on an ALIAS target.

justing-bq · 2026-01-30T17:41:57Z

We don't need iodbc anymore?

-Original file line number
+Diff line change
@@ Expand Up / @@ -357,6 +357,10 @@ jobs: @@
           ARROW_BUILD_TESTS: ON
           ARROW_FLIGHT_SQL_ODBC: ON
           ARROW_HOME: /tmp/local
+          ARROW_DEPENDENCY_USE_SHARED: OFF
+          ARROW_DEPENDENCY_SOURCE: BUNDLED
+          ARROW_MIMALLOC: OFF
+          CMAKE_CXX_STANDARD: "20"
         steps:
           - name: Checkout Arrow
             uses: actions/checkout@v6.0.0
@@ Expand All / @@ -366,6 +370,19 @@ jobs: @@
           - name: Install Dependencies
             run: |
               brew bundle --file=cpp/Brewfile
+              # We want to use bundled RE2 for static linking. If
+              # Homebrew's RE2 is installed, its header file may be used.
+              # We uninstall Homebrew's RE2 to ensure using bundled RE2.
+              brew uninstall grpc || : # gRPC depends on RE2
+              brew uninstall grpc@1.54 || : # gRPC 1.54 may be installed too
+              brew uninstall re2
+              # We want to use bundled Protobuf for static linking. If
+              # Homebrew's Protobuf is installed, its library file may be
+              # used on test  We uninstall Homebrew's Protobuf to ensure using
+              # bundled Protobuf.
+              brew uninstall protobuf
+              # We want to use bundled Boost for static linking.
+              brew uninstall boost
           - name: Setup ccache
             run: |
               ci/scripts/ccache_setup.sh
@@ Expand Down Expand Up / @@ -394,6 +411,10 @@ jobs: @@
               export ODBC_INCLUDE_DIR=$LIBIODBC_DIR/include
               export CXXFLAGS="$CXXFLAGS -I$ODBC_INCLUDE_DIR"
               ci/scripts/cpp_build.sh $(pwd) $(pwd)/build
+          - name: Register Flight SQL ODBC Driver
+            run: |
+              chmod +x cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc.sh
+              sudo cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc.sh $(pwd)/build/cpp/debug/libarrow_flight_sql_odbc.dylib
           - name: Test
             shell: bash
             run: |
@@ Expand Down Expand Up / @@ -427,6 +448,7 @@ jobs: @@
           CMAKE_INSTALL_PREFIX: /usr
           VCPKG_BINARY_SOURCES: 'clear;nugettimeout,600;nuget,GitHub,readwrite'
           VCPKG_DEFAULT_TRIPLET: x64-windows
+          CMAKE_CXX_STANDARD: "20"
         steps:
           - name: Disable Crash Dialogs
             run: |
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -59,7 +59,6 @@ case "$(uname)" in @@
         ;;
       Darwin)
         n_jobs=$(sysctl -n hw.ncpu)
-        exclude_tests+=("arrow-flight-sql-odbc-test")
         # TODO: https://github.com/apache/arrow/issues/40410
         exclude_tests+=("arrow-s3fs-test")
         ;;
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -1107,6 +1107,11 @@ function(build_boost) @@
       else()
         list(APPEND BOOST_EXCLUDE_LIBRARIES uuid)
       endif()
+      if(ARROW_FLIGHT_SQL_ODBC)
+        list(APPEND BOOST_INCLUDE_LIBRARIES beast xpressive)
+      else()
+        list(APPEND BOOST_EXCLUDE_LIBRARIES beast xpressive)
+      endif()
       set(BOOST_SKIP_INSTALL_RULES ON)
       if(NOT ARROW_ENABLE_THREADING)
         set(BOOST_UUID_LINK_LIBATOMIC OFF)
@@ Expand Down Expand Up / @@ -3024,8 +3029,8 @@ function(build_cares) @@
       if(APPLE)
         # libresolv must be linked from c-ares version 1.16.1
         find_library(LIBRESOLV_LIBRARY NAMES resolv libresolv REQUIRED)
-        set_target_properties(c-ares::cares PROPERTIES INTERFACE_LINK_LIBRARIES
-                                                       "${LIBRESOLV_LIBRARY}")
+        set_target_properties(c-ares PROPERTIES INTERFACE_LINK_LIBRARIES
+                                                "${LIBRESOLV_LIBRARY}")
       endif()
       set(ARROW_BUNDLED_STATIC_LIBS
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,11 @@ @@
     # GH-44792: Arrow will switch to C++ 20
     set(CMAKE_CXX_STANDARD 20)
+    if(APPLE)
+      # CMAKE_FIND_LIBRARY_SUFFIXES.
+      set(APPEND CMAKE_FIND_LIBRARY_SUFFIXES ".a")
+    endif()
     if(WIN32)
       if(MSVC_VERSION GREATER_EQUAL 1900)
         set(ODBCINST legacy_stdio_definitions odbccp32 shlwapi)
@@ Expand Down Expand Up / @@ -61,33 +66,56 @@ if(WIN32) @@
       list(APPEND ARROW_FLIGHT_SQL_ODBC_SRCS odbc.def install/versioninfo.rc)
     endif()
-    add_arrow_lib(arrow_flight_sql_odbc
-                  CMAKE_PACKAGE_NAME
-                  ArrowFlightSqlOdbc
-                  PKG_CONFIG_NAME
-                  arrow-flight-sql-odbc
-                  OUTPUTS
-                  ARROW_FLIGHT_SQL_ODBC_LIBRARIES
-                  SOURCES
-                  ${ARROW_FLIGHT_SQL_ODBC_SRCS}
-                  DEPENDENCIES
-                  arrow_flight_sql
-                  DEFINITIONS
-                  UNICODE
-                  SHARED_LINK_FLAGS
-                  ${ARROW_VERSION_SCRIPT_FLAGS} # Defined in cpp/arrow/CMakeLists.txt
-                  SHARED_LINK_LIBS
-                  arrow_flight_sql_shared
-                  SHARED_INSTALL_INTERFACE_LIBS
-                  ArrowFlight::arrow_flight_sql_shared
-                  STATIC_LINK_LIBS
-                  arrow_flight_sql_static
-                  STATIC_INSTALL_INTERFACE_LIBS
-                  ArrowFlight::arrow_flight_sql_static
-                  SHARED_PRIVATE_LINK_LIBS
-                  ODBC::ODBC
-                  ${ODBCINST}
-                  arrow_odbc_spi_impl)
+    # On Windows, dynmaic build for ODBC is supported.
+    # On unix systems, static build for ODBC is supported, all libraries are linked statically on unix.
+    if(WIN32)
+      add_arrow_lib(arrow_flight_sql_odbc
+                    CMAKE_PACKAGE_NAME
+                    ArrowFlightSqlOdbc
+                    PKG_CONFIG_NAME
+                    arrow-flight-sql-odbc
+                    OUTPUTS
+                    ARROW_FLIGHT_SQL_ODBC_LIBRARIES
+                    SOURCES
+                    ${ARROW_FLIGHT_SQL_ODBC_SRCS}
+                    DEFINITIONS
+                    UNICODE
+                    SHARED_LINK_FLAGS
+                    ${ARROW_VERSION_SCRIPT_FLAGS} # Defined in cpp/arrow/CMakeLists.txt
+                    SHARED_LINK_LIBS
+                    arrow_flight_sql_shared
+                    arrow_odbc_spi_impl
+                    SHARED_INSTALL_INTERFACE_LIBS
+                    ArrowFlight::arrow_flight_sql_shared
+                    STATIC_LINK_LIBS
+                    arrow_flight_sql_static
+                    STATIC_INSTALL_INTERFACE_LIBS
+                    ArrowFlight::arrow_flight_sql_static
+                    SHARED_PRIVATE_LINK_LIBS
+                    ODBC::ODBC
+                    ${ODBCINST})
+    else()
+      # Unix
+      add_arrow_lib(arrow_flight_sql_odbc
+                    CMAKE_PACKAGE_NAME
+                    ArrowFlightSqlOdbc
+                    PKG_CONFIG_NAME
+                    arrow-flight-sql-odbc
+                    OUTPUTS
+                    ARROW_FLIGHT_SQL_ODBC_LIBRARIES
+                    SOURCES
+                    ${ARROW_FLIGHT_SQL_ODBC_SRCS}
+                    DEFINITIONS
+                    UNICODE
+                    SHARED_LINK_FLAGS
+                    ${ARROW_VERSION_SCRIPT_FLAGS} # Defined in cpp/arrow/CMakeLists.txt
+                    STATIC_LINK_LIBS
+                    iodbc
+                    ODBC::ODBC
+                    ${ODBCINST}
+                    SHARED_LINK_LIBS
+                    arrow_odbc_spi_impl)
+    endif()
     foreach(LIB_TARGET ${ARROW_FLIGHT_SQL_ODBC_LIBRARIES})
       target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_FLIGHT_SQL_ODBC_EXPORTING)
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,7 @@ @@
     # specific language governing permissions and limitations
     # under the License.
-    add_library(arrow_odbc_spi_impl
+    add_library(arrow_odbc_spi_impl STATIC
                 accessors/binary_array_accessor.cc
                 accessors/binary_array_accessor.h
                 accessors/boolean_array_accessor.cc
@@ Expand Down Expand Up / @@ -133,8 +133,11 @@ endif() @@
     if(APPLE)
       target_include_directories(arrow_odbc_spi_impl SYSTEM BEFORE PUBLIC ${ODBC_INCLUDE_DIR})
       target_link_libraries(arrow_odbc_spi_impl
-                            PUBLIC arrow_flight_sql_shared arrow_compute_shared Boost::locale
-                                   iodbc)
+                            PUBLIC arrow_flight_sql_static
+                                   arrow_compute_static
+                                   Boost::locale
+                                   Boost::headers
+                                   RapidJSON)
     else()
       find_package(ODBC REQUIRED)
       target_include_directories(arrow_odbc_spi_impl PUBLIC ${ODBC_INCLUDE_DIR})
@@ Expand All / @@ -143,14 +146,6 @@ else() @@
                                    ${ODBCINST})
     endif()
-    set_target_properties(arrow_odbc_spi_impl
-                          PROPERTIES ARCHIVE_OUTPUT_DIRECTORY
-                                     ${CMAKE_BINARY_DIR}/$<CONFIG>/lib
-                                     LIBRARY_OUTPUT_DIRECTORY
-                                     ${CMAKE_BINARY_DIR}/$<CONFIG>/lib
-                                     RUNTIME_OUTPUT_DIRECTORY
-                                     ${CMAKE_BINARY_DIR}/$<CONFIG>/lib)
     # CLI
     add_executable(arrow_odbc_spi_impl_cli main.cc)
     set_target_properties(arrow_odbc_spi_impl_cli
@@ Expand All / @@ -159,6 +154,16 @@ set_target_properties(arrow_odbc_spi_impl_cli @@
     target_link_libraries(arrow_odbc_spi_impl_cli arrow_odbc_spi_impl)
     # Unit tests
+    # On Windows, dynamic linking ODBC is supported.
+    # On unix systems, static linking ODBC is supported, thus the library linking is static.
+    if(WIN32)
+      set(ODBC_SPI_IMPL_TEST_LINK_LIBS arrow_flight_testing_shared)
+    else()
+      # unix
+      set(ODBC_SPI_IMPL_TEST_LINK_LIBS arrow_flight_testing_static)
+    endif()
     add_arrow_test(odbc_spi_impl_test
                    SOURCES
                    accessors/boolean_array_accessor_test.cc
@@ Expand All / @@ -177,4 +182,4 @@ add_arrow_test(odbc_spi_impl_test @@
                    util_test.cc
                    EXTRA_LINK_LIBS
                    arrow_odbc_spi_impl
-                   arrow_flight_testing_shared)
+                   ${ODBC_SPI_IMPL_TEST_LINK_LIBS})

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build ODBC statically on macOS #153

Uh oh!

Diff view

Diff view

There are no files selected for viewing

justing-bq Jan 30, 2026

Uh oh!

alinaliBQ Jan 29, 2026

Uh oh!

justing-bq Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,7 @@ @@
     #include <string>
-    #include "config/configuration.h"
+    #include "arrow/flight/sql/odbc/odbc_impl/config/configuration.h"
     namespace arrow::flight::sql::odbc {
     namespace config {
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,6 @@ @@
     #include <sql.h>
     #include <sqlext.h>
     #include <sqltypes.h>
-    #include <boost/variant.hpp>
     #include <optional>
     #include <utility>
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,7 @@ @@
     // specific language governing permissions and limitations
     // under the License.
-    #include "ui/add_property_window.h"
+    #include "arrow/flight/sql/odbc/odbc_impl/ui/add_property_window.h"
     #include <Windowsx.h>
@@ Expand All / @@ -25,8 +25,8 @@ @@
     #include <commctrl.h>
     #include "arrow/flight/sql/odbc/odbc_impl/exceptions.h"
-    #include "ui/custom_window.h"
-    #include "ui/window.h"
+    #include "arrow/flight/sql/odbc/odbc_impl/ui/custom_window.h"
+    #include "arrow/flight/sql/odbc/odbc_impl/ui/window.h"
     namespace arrow::flight::sql::odbc {
     namespace config {
@@ Expand Down @@

Build ODBC statically on macOS #153

Are you sure you want to change the base?

Uh oh!

Build ODBC statically on macOS #153

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

justing-bq Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

alinaliBQ Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

justing-bq Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!