Skip to content

Commit e142de9

Browse files
committed
fix ci
``` rangeValCopy: each iteration copies 128 bytes (consider pointers or indexing) (gocritic) for _, di := range infos { ```
1 parent 5d6a964 commit e142de9

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

cmd/miniscript/main.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func errpanic(err error) {
5555
}
5656
}
5757

58-
func isBitBox02(deviceInfo usb.DeviceInfo) bool {
58+
func isBitBox02(deviceInfo *usb.DeviceInfo) bool {
5959
return (deviceInfo.Product == common.FirmwareHIDProductStringStandard ||
6060
deviceInfo.Product == common.FirmwareHIDProductStringBTCOnly) &&
6161
deviceInfo.VendorID == bitbox02VendorID &&
@@ -176,10 +176,11 @@ func (m multipath) derivationSuffix(isChange bool, addressIndex uint32) []uint32
176176
}
177177

178178
func main() {
179-
deviceInfo := func() usb.DeviceInfo {
179+
deviceInfo := func() *usb.DeviceInfo {
180180
infos, err := usb.EnumerateHid(0, 0)
181181
errpanic(err)
182-
for _, di := range infos {
182+
for idx := range infos {
183+
di := &infos[idx]
183184
if di.Serial == "" || di.Product == "" {
184185
continue
185186
}

cmd/paymentrequest/main.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ func errpanic(err error) {
5050
}
5151
}
5252

53-
func isBitBox02(deviceInfo usb.DeviceInfo) bool {
53+
func isBitBox02(deviceInfo *usb.DeviceInfo) bool {
5454
return (deviceInfo.Product == common.FirmwareHIDProductStringStandard ||
5555
deviceInfo.Product == common.FirmwareHIDProductStringBTCOnly) &&
5656
deviceInfo.VendorID == bitbox02VendorID &&
@@ -59,10 +59,11 @@ func isBitBox02(deviceInfo usb.DeviceInfo) bool {
5959
}
6060

6161
func main() {
62-
deviceInfo := func() usb.DeviceInfo {
62+
deviceInfo := func() *usb.DeviceInfo {
6363
infos, err := usb.EnumerateHid(0, 0)
6464
errpanic(err)
65-
for _, di := range infos {
65+
for idx := range infos {
66+
di := &infos[idx]
6667
if di.Serial == "" || di.Product == "" {
6768
continue
6869
}

cmd/playground/main.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func errpanic(err error) {
4545
}
4646
}
4747

48-
func isBitBox02(deviceInfo usb.DeviceInfo) bool {
48+
func isBitBox02(deviceInfo *usb.DeviceInfo) bool {
4949
return (deviceInfo.Product == common.FirmwareHIDProductStringStandard ||
5050
deviceInfo.Product == common.FirmwareHIDProductStringBTCOnly) &&
5151
deviceInfo.VendorID == bitbox02VendorID &&
@@ -172,10 +172,11 @@ func signFromTxID(device *firmware.Device, txID string) {
172172
}
173173

174174
func main() {
175-
deviceInfo := func() usb.DeviceInfo {
175+
deviceInfo := func() *usb.DeviceInfo {
176176
infos, err := usb.EnumerateHid(0, 0)
177177
errpanic(err)
178-
for _, di := range infos {
178+
for idx := range infos {
179+
di := &infos[idx]
179180
if di.Serial == "" || di.Product == "" {
180181
continue
181182
}
@@ -186,6 +187,7 @@ func main() {
186187
panic("could no find a bitbox02")
187188

188189
}()
190+
189191
hidDevice, err := deviceInfo.Open()
190192
errpanic(err)
191193
const bitboxCMD = 0x80 + 0x40 + 0x01

0 commit comments

Comments
 (0)