Improve command error responses

Author: TBlueF

gradle/libs.versions.toml

@@ -1,6 +1,6 @@
 [versions]
 adventure = "4.17.0"
-bluecommands = "1.3.3"
+bluecommands = "1.3.4"
 bstats = "2.2.1"
 configurate = "4.1.2"
 junit = "5.8.2"

implementations/spigot/src/main/java/de/bluecolored/bluemap/bukkit/BukkitCommands.java

@@ -36,10 +36,7 @@
 import org.bukkit.event.server.TabCompleteEvent;
 import org.jetbrains.annotations.NotNull;
 
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Comparator;
-import java.util.List;
+import java.util.*;
 
 import static de.bluecolored.bluemap.common.commands.TextFormat.NEGATIVE_COLOR;
 import static net.kyori.adventure.text.Component.text;
@@ -114,9 +111,15 @@ public boolean execute(@NotNull CommandSender sender, @NotNull String commandLab
             CommandExecutor.ExecutionResult executionResult = commandExecutor.execute(result);
 
             if (executionResult.parseFailure()) {
-                result.getFailures().stream()
-                        .max(Comparator.comparing(ParseFailure::getPosition))
-                        .ifPresent(failure -> context.sendMessage(text(failure.getReason()).color(NEGATIVE_COLOR)));
+                Optional<ParseFailure<CommandSource, Object>> failure = result.getFailures().stream()
+                        .max(Comparator.comparing(ParseFailure::getPosition));
+
+                if (failure.isPresent()) {
+                    context.sendMessage(text(failure.get().getReason()).color(NEGATIVE_COLOR));
+                } else {
+                    context.sendMessage(text("Unknown command!").color(NEGATIVE_COLOR));
+                }
+
                 return false;
             }
 

implementations/sponge/src/main/java/de/bluecolored/bluemap/sponge/SpongeCommands.java

@@ -78,9 +78,15 @@ public CommandResult process(CommandCause cause, ArgumentReader.Mutable argument
             CommandExecutor.ExecutionResult executionResult = commandExecutor.execute(result);
 
             if (executionResult.parseFailure()) {
-                result.getFailures().stream()
-                        .max(Comparator.comparing(ParseFailure::getPosition))
-                        .ifPresent(failure -> context.sendMessage(text(failure.getReason()).color(NEGATIVE_COLOR)));
+                Optional<ParseFailure<CommandSource, Object>> failure = result.getFailures().stream()
+                        .max(Comparator.comparing(ParseFailure::getPosition));
+
+                if (failure.isPresent()) {
+                    context.sendMessage(text(failure.get().getReason()).color(NEGATIVE_COLOR));
+                } else {
+                    context.sendMessage(text("Unknown command!").color(NEGATIVE_COLOR));
+                }
+
                 return CommandResult.builder()
                         .result(0)
                         .build();