Calling a contact causes activation of other contacts

[DealTheAl]

What version of iFruitAddon2 are you using?

3.0.2

A clear and concise description of what the problem is.

Calling a contact causes the activation of other contacts.
For example if two contacts activates something like opening a menu, calling one will result in two menu opened the one of the contacts called plus another one.
It seems to not happening with all the contacts.
It didn't happen with the previous version.

Steps to reproduce the issue.

Example: create a nativeUI menu that opens up when calling a contact for two different contacts.
I have several mods that creates different phone contacts.

Thanks in advance.

Edit:
It seems reloading scripts in-game fixes the issue.

[Bob74]

Hi, I have never encountered this, could you upload the log files (ScriptHookVDotNet and iFruitAddon2)?

[DealTheAl]

Yes, the iFruitAddon2 log is empty while the ScriptHookVDotNet doesn't show anything strange....

ScriptHookVDotNet.log

It happens when I load the game.. Strangely the few contacts that are "mixed up" are even missing like they are "hidden" behind another one

For more details:
for example two mod's contacts that are mixed up when loading the game are "Forever Together" and "Dealien's Adjustments".
The "Forever Together" contact is there but the "adjustments" not and when I activate the first one both are being activated at the same time.

[Bob74]

Ok I have the same issue with adjustments. This is weird, it really looks like it forces its way into an already existing contact. Not sure what i can do about this but I'll give it a look.

[Bob74]

Well, since Dealien obfuscated its code, I cannot see what they did to have this behavior or how to fix it. But, you can edit iFruitAddon2 config file (scripts\iFruitAddon2\config.ini), you can set StartIndex to 41 instead of 40. Adjustments will still take contact n°40 but all your other contacts will be below it.

I even tried starting at 42 but it seems Adjustment's contact is hardcoded to 40

[DealTheAl]

I know that the code is no different from the other mods when talking about adding contacts:

    _iFruit = new CustomiFruit();

    Function.Call(Hash.REQUEST_STREAMED_TEXTURE_DICT, "DIA_CLIFFORD", true); 


    contactA = new iFruitContact("Dealien's Adjustments");
    contactA.Answered += ContactAnswered;  
    contactA.DialTimeout = 100;           
    contactA.Active = true;               
    contactA.Icon = new ContactIcon("DIA_CLIFFORD"); 
    _iFruit.Contacts.Add(contactA);       

The strange thing is that with the previous version of iFruitAddon2 the issue wasn't there.
Also as soon as you reload the scripts in-game the whole contact list is working as intended.
Strange indeed.
Thanks by the way for what you do.

[Bob74]

Didn't realised it was your mod. I tried using iFruitAddon2 3.0.1 and there is still something odd, Adjustments adds one real contact at 40 and an empty one at 41:

I removed Dealien_Adjustments ini dll and sav files and there is no gap anymore, the first contact starts at 40.

But this is not related to our current problem. I think I figured out what has changed since 3.0.1, the temp file holding the current contact id is created a bit later in the script in 3.0.2.
I was refactoring the lib a bit to get rid of this temp file, I will try to get back to it then 😅

[Bob74]

@DealTheAl Was testing a bit my modifications and stumbled into something. When I switch characters, the Partner contact is added again.
Actually it looks like the Contact Collection is emptied and a new Partner contact is added (since the previous contact disappears and the new one appears one slot under the previous one). It does this after each character switch and only with Partner, when removing the mod the contact list is well ordered.

Do you know if some code on your side resets your collection on certain conditions?

[Bob74]

Latest version should fix the issue with overriding contacts: https://github.com/Bob74/iFruitAddon2/releases/tag/v3.1.0

[DealTheAl]

Hey, sorry for the late response. I wasn't at home. The new version unfortunately didn't fix it for me but I think I've found where I could have failed.
Each time the player changes character (and obviously at the start of the game because of the starting assigned model hash) this is called:

        if (contactA != null) { _iFruit.Contacts.Remove(contactA); }  // <---   I think this is the problem. But it worked with the previous versions of iFruitAddon2
        contactA = new iFruitContact(ParName.ToString());
        contactA.Answered += ContactAnswered;  
        contactA.DialTimeout = 1;      
        contactA.Active = true;            
        contactA.Icon = ContactIcon.ChatIcon;    
        _iFruit.Contacts.Add(contactA);   

Is there something missing? Maybe refreshing the contact list after removing it?

[Bob74]

Ok I get it, actually your are not supposed to remove a contact, it will mess with the contact indexes and create empty spaces. What you can do is save the reference to your contact object in a variable and simply reassign the properties when needed using this variable:

readonly CustomiFruit _iFruit;

readonly iFruitContact _contactA = new iFruitContact("New contact");

public iFruitAddon2Example()
{
    _iFruit = new CustomiFruit();

    // Common properties
    _contactA.DialTimeout = 1;
    _contactA.Active = true;
    _contactA.Icon = ContactIcon.ChatIcon;
    _iFruit.Contacts.Add(_contactA);

    // Assign/update character related properties
    handleCharacterParams()

    Tick += OnTick;
}

Then you can call something like this after character switch instead of removing the contact:

private handleCharacterParams()
{
    if (Michael)
    {
        _contactA.Name = "For Michael";
        _contactA.Answered += AnswerMichael;
        _contactA.Answered -= AnswerFranklin;
        _contactA.Answered -= AnswerTrevor;
    }
    if (Franklin)
    {
        _contactA.Name = "For Franklin";
        _contactA.Answered -= AnswerMichael;
        _contactA.Answered += AnswerFranklin;
        _contactA.Answered -= AnswerTrevor;
    }
    if (Trevor)
    {
        _contactA.Name = "For Trevor";
        _contactA.Answered -= AnswerMichael;
        _contactA.Answered -= AnswerFranklin;
        _contactA.Answered += AnswerTrevor;
    }
}

The name will be updated after closing and reopening the phone, so it will be updated when switching character.

[DealTheAl]

Alright, that's a good way, with several trial and error I tried removing all my scripts and adding them individually.
The overlapping/missing contact error came up again if some scripts call that "f (contactA != null) { _iFruit.Contacts.Remove(contactA); } "
Most of my scripts rely on iFruitAddon2 so there are quite a lot of contacts added, around 10-ish..
My question is why in the previous versions this wasn't an issue.
Unfortunately I also need to dinamically be able to remove contacts sometimes (character leaves an organization, ecc....)
Is there a workaround I could use (I will soon try to use "contactA.Active = false;") or should I warn users to stick with the v3.0.1 ?
Anyway I'm willing to help in any way I can.
Thanks again!

[Bob74]

I didn't think it would be useful to remove contacts but given your examples it would be a good thing to add.
I will have to do a bit more testing to understand what's going on and why can it still overrides contacts.

For now, you can suggest your users to stay on 3.0.1.

[Bob74]

There is something I don't understand. On my debug build, the contact Dealien's Adjustments does not log a message when the constructor is called whereas other mods do log (including Dealien_ForeverTogether).

It is like the contact is created without calling the expected constructor. I don't think you use some shady tricks on your own to create the contact object but could you try building your mod without obfuscation to give it a try?

[DealTheAl]

Is there a way I can give that to you privately? Unfortunately because of previous negative experiences I had to start obfuscating but I feel I can totally trust you.
Anyway in that mod there's simply this:

    _iFruit = new CustomiFruit();

    contactA = new iFruitContact("Dealien's Adjustments");
    contactA.Answered += ContactAnswered;  
    contactA.DialTimeout = 100;  
    contactA.Active = true;  
    contactA.Icon = new ContactIcon("DIA_CLIFFORD"); 
    _iFruit.Contacts.Add(contactA);  

As you said nothing shady. Not even the _iFruit.Contacts.Remove()