@@ -109,7 +109,7 @@ abstract contract BasicSwap7683 is Base7683 {
109109 */
110110 function _refundOrders (OnchainCrossChainOrder[] memory _orders , bytes32 [] memory _orderIds ) internal override {
111111 // at this point we are sure all orders are NOT filled, use the first order to get the originDomain
112- // if some order differs on the originDomain ir can be re-refunded later
112+ // if some order differs on the originDomain it can be re-refunded later
113113 _dispatchRefund (OrderEncoder.decode (_orders[0 ].orderData).originDomain, _orderIds);
114114 }
115115
@@ -139,11 +139,11 @@ abstract contract BasicSwap7683 is Base7683 {
139139 bytes32 _receiver
140140 ) internal virtual {
141141 (
142- bool validOpenOrder ,
142+ bool isEligible ,
143143 OrderData memory orderData
144- ) = _isValidOpenOrder (_messageOrigin, _messageSender, _orderId);
144+ ) = _checkOrderEligibility (_messageOrigin, _messageSender, _orderId);
145145
146- if (! validOpenOrder ) return ;
146+ if (! isEligible ) return ;
147147
148148 orderStatus[_orderId] = SETTLED;
149149
@@ -164,11 +164,11 @@ abstract contract BasicSwap7683 is Base7683 {
164164 */
165165 function _handleRefundOrder (uint32 _messageOrigin , bytes32 _messageSender , bytes32 _orderId ) internal virtual {
166166 (
167- bool validOpenOrder ,
167+ bool isEligible ,
168168 OrderData memory orderData
169- ) = _isValidOpenOrder (_messageOrigin, _messageSender, _orderId);
169+ ) = _checkOrderEligibility (_messageOrigin, _messageSender, _orderId);
170170
171- if (! validOpenOrder ) return ;
171+ if (! isEligible ) return ;
172172
173173 orderStatus[_orderId] = REFUNDED;
174174
@@ -181,14 +181,14 @@ abstract contract BasicSwap7683 is Base7683 {
181181 }
182182
183183 /**
184- * @notice Validates an open order.
185- * @dev Checks that the order is open and that its destination domain and settler match the provided parameters .
184+ * @notice Checks if order is eligible for settlement or refund .
185+ * @dev Order must be OPENED and the message was sent from the appropriated chain and contract .
186186 * @param _messageOrigin The origin domain of the message.
187187 * @param _messageSender The sender identifier of the message.
188188 * @param _orderId The unique identifier of the order.
189189 * @return A boolean indicating if the order is valid, and the decoded OrderData structure.
190190 */
191- function _isValidOpenOrder (
191+ function _checkOrderEligibility (
192192 uint32 _messageOrigin ,
193193 bytes32 _messageSender ,
194194 bytes32 _orderId
0 commit comments