diff --git a/class/Command/ValidateActivityImport.php b/class/Command/ValidateActivityImport.php index d66abe60..af9ace25 100644 --- a/class/Command/ValidateActivityImport.php +++ b/class/Command/ValidateActivityImport.php @@ -1,4 +1,5 @@ prepare('UPDATE intern_import_activity SET validated_on = :now, validation_errors = \'\' WHERE id = :id AND import_id = :import_id'); diff --git a/class/DataProvider/Major/TestMajorsProvider.php b/class/DataProvider/Major/TestMajorsProvider.php index ff276a0d..c44e6196 100644 --- a/class/DataProvider/Major/TestMajorsProvider.php +++ b/class/DataProvider/Major/TestMajorsProvider.php @@ -1,4 +1,5 @@ major_code, $obj->major_desc, $obj->levl); } @@ -73,5 +76,4 @@ private function createMajor($majorCode, $majorDesc, $level) return $major; } - } diff --git a/class/DataProvider/Student/LocalDbStudentDataProvider.php b/class/DataProvider/Student/LocalDbStudentDataProvider.php index 135f4348..877e0245 100644 --- a/class/DataProvider/Student/LocalDbStudentDataProvider.php +++ b/class/DataProvider/Student/LocalDbStudentDataProvider.php @@ -1,4 +1,5 @@ fetch(\PDO::FETCH_ASSOC); - if($result === false){ + if ($result === false) { throw new StudentNotFoundException('Could not find student in local data with id: ' . $studentId); } @@ -48,7 +51,7 @@ public function getStudent($studentId){ return $student; } - protected function plugValues(&$student, Array $data) + protected function plugValues(&$student, array $data) { /********************** * Basic Demographics * @@ -62,7 +65,7 @@ protected function plugValues(&$student, Array $data) $student->setPreferredName($data['preferred_name']); $student->setGender($data['gender']); - if($data['confidential'] === 'Y'){ + if ($data['confidential'] === 'Y') { $student->setConfidentialFlag(true); } else { $student->setConfidentialFlag(false); @@ -77,9 +80,9 @@ protected function plugValues(&$student, Array $data) * Academic Info * *****************/ // Campus - if($data['campus'] === 'main_campus'){ + if ($data['campus'] === 'main_campus') { $student->setCampus(Student::MAIN_CAMPUS); - } else if ($data['campus'] != ''){ + } else if ($data['campus'] != '') { $student->setCampus($data['campus']); } @@ -91,15 +94,17 @@ protected function plugValues(&$student, Array $data) // Majors - Only one allowed here (this differs from WebServiceDataProvider) // code and description fields must both be not null and not empty string to add a major - if($data['major_code'] !== null && $data['major_code'] !== '' - && $data['major_description'] !== null && $data['major_description'] !== '') { - $student->addMajor(new AcademicMajor($data['major_code'], $data['major_description'], $data['level'])); + if ( + $data['major_code'] !== null && $data['major_code'] !== '' + && $data['major_description'] !== null && $data['major_description'] !== '' + ) { + $student->addMajor(new AcademicMajor($data['major_code'], $data['major_description'], $data['level'], null, null, 0)); } $student->setGpa(round($data['gpa'], 4)); // Grad date, if available - if($data['grad_date'] !== null && $data['grad_date'] != '') { + if ($data['grad_date'] !== null && $data['grad_date'] != '') { $student->setGradDateFromString($data['grad_date']); } @@ -125,7 +130,7 @@ public function getCreditHours(string $studentId, string $term) $result = $stmt->fetch(\PDO::FETCH_ASSOC); - if($result === false){ + if ($result === false) { throw new StudentNotFoundException('Could not find student in local data with id: ' . $studentId); } diff --git a/class/DataProvider/Student/StudentDataProviderFactory.php b/class/DataProvider/Student/StudentDataProviderFactory.php index b6c4e8e4..6b828b33 100644 --- a/class/DataProvider/Student/StudentDataProviderFactory.php +++ b/class/DataProvider/Student/StudentDataProviderFactory.php @@ -1,4 +1,5 @@ getStudentDataSource(); - switch($providerName){ + switch ($providerName) { case 'localDataProvider': return new LocalDbStudentDataProvider(); case 'webServiceDataProvider': @@ -54,7 +56,6 @@ public static function getProvider(): StudentDataProvider return new TestWebServiceDataProvider(\Current_User::getUsername()); default: throw new \UnexpectedValueException('No configuration for student data provider.'); - } } } diff --git a/class/StudentFactory.php b/class/StudentFactory.php index efa8b799..1b6128ef 100644 --- a/class/StudentFactory.php +++ b/class/StudentFactory.php @@ -1,4 +1,5 @@