Skip to content

Commit 77bbafd

Browse files
committed
Rename "Builder" to "Manager"
1 parent b0800a4 commit 77bbafd

File tree

3 files changed

+30
-30
lines changed

3 files changed

+30
-30
lines changed

src/StaticEntity.php

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
abstract class StaticEntity implements StaticEntityInterface
1919
{
2020
/**
21-
* @var StaticEntityBuilder
21+
* @var StaticEntityManager
2222
*/
23-
private static $builders;
23+
private static $managers;
2424

2525
/**
2626
* @var mixed
@@ -36,7 +36,7 @@ abstract class StaticEntity implements StaticEntityInterface
3636
*/
3737
static public function get($identifier)
3838
{
39-
return self::getBuilder()->get($identifier);
39+
return self::getManager()->get($identifier);
4040
}
4141

4242
/**
@@ -50,7 +50,7 @@ static public function get($identifier)
5050
*/
5151
static public function hasId($id)
5252
{
53-
return self::getBuilder()->hasId($id);
53+
return self::getManager()->hasId($id);
5454
}
5555

5656
/**
@@ -62,7 +62,7 @@ static public function hasId($id)
6262
*/
6363
static public function getAll()
6464
{
65-
return self::getBuilder()->getAll();
65+
return self::getManager()->getAll();
6666
}
6767

6868
/**
@@ -76,7 +76,7 @@ static public function getAll()
7676
*/
7777
static public function getAssociative($valueKey = 'name')
7878
{
79-
return self::getBuilder()->getAssociative($valueKey);
79+
return self::getManager()->getAssociative($valueKey);
8080
}
8181

8282
/**
@@ -88,7 +88,7 @@ static public function getAssociative($valueKey = 'name')
8888
*/
8989
static public function getIds()
9090
{
91-
return self::getBuilder()->getIds();
91+
return self::getManager()->getIds();
9292
}
9393

9494
/**
@@ -103,29 +103,29 @@ static public function getIds()
103103
*/
104104
static public function toId($idOrEntity)
105105
{
106-
return self::getBuilder()->convertToId($idOrEntity);
106+
return self::getManager()->convertToId($idOrEntity);
107107
}
108108

109109

110110
/**
111-
* Get the StaticEntity builder
111+
* Get the StaticEntity manager for the current class
112112
*
113113
* @throws \Exception
114-
* @return StaticEntityBuilder
114+
* @return StaticEntityManager
115115
*/
116-
private static function getBuilder()
116+
private static function getManager()
117117
{
118118
$class = get_called_class();
119119

120120
if (__CLASS__ === $class) {
121121
throw new \Exception('You cannot call methods directly on StaticEntity class');
122122
}
123123

124-
if (!isset(self::$builders[$class])) {
125-
self::$builders[$class] = new StaticEntityBuilder($class);
124+
if (!isset(self::$managers[$class])) {
125+
self::$managers[$class] = new StaticEntityManager($class);
126126
}
127127

128-
return self::$builders[$class];
128+
return self::$managers[$class];
129129
}
130130

131131
/**

src/StaticEntityBuilder.php renamed to src/StaticEntityManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*
1616
* @author Thierry Goettelmann <thierry@byscripts.info>
1717
*/
18-
class StaticEntityBuilder
18+
class StaticEntityManager
1919
{
2020
private $class;
2121

tests/StaticEntityBuilderTest.php

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Byscripts\StaticEntity\Tests;
44

55
use Byscripts\StaticEntity\StaticEntity;
6-
use Byscripts\StaticEntity\StaticEntityBuilder;
6+
use Byscripts\StaticEntity\StaticEntityManager;
77
use Byscripts\StaticEntity\Tests\Fixtures\Civility;
88
use Byscripts\StaticEntity\Tests\Fixtures\InvalidData;
99
use Byscripts\StaticEntity\Tests\Fixtures\InvalidDataSet;
@@ -18,7 +18,7 @@ class StaticEntityBuilderTest extends \PHPUnit_Framework_TestCase
1818
{
1919
public function testInstance()
2020
{
21-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
21+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
2222

2323
/** @var $civility Civility */
2424
$civility = $builder->get('mr');
@@ -31,15 +31,15 @@ public function testInstance()
3131

3232
public function testNotFound()
3333
{
34-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
34+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
3535
$civility = $builder->get('not-exists');
3636

3737
$this->assertNull($civility);
3838
}
3939

4040
public function testSameInstances()
4141
{
42-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
42+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
4343

4444
$civility1 = $builder->get('mr');
4545
$civility2 = $builder->get('mr');
@@ -53,7 +53,7 @@ public function testSameInstances()
5353
*/
5454
public function testInvalidDataSet()
5555
{
56-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\InvalidDataSet');
56+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\InvalidDataSet');
5757
$builder->get('foo');
5858
}
5959

@@ -63,7 +63,7 @@ public function testInvalidDataSet()
6363
*/
6464
public function testInvalidData()
6565
{
66-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\InvalidData');
66+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\InvalidData');
6767
$builder->get('foo');
6868
}
6969

@@ -73,13 +73,13 @@ public function testInvalidData()
7373
*/
7474
public function testMissingProperty()
7575
{
76-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\MissingProperty');
76+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\MissingProperty');
7777
$builder->get('foo');
7878
}
7979

8080
public function testExists()
8181
{
82-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
82+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
8383

8484
$this->assertTrue(
8585
$builder->hasId('mr')
@@ -92,7 +92,7 @@ public function testExists()
9292

9393
public function testToId()
9494
{
95-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
95+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
9696

9797
$civility = $builder->get('mr');
9898

@@ -107,13 +107,13 @@ public function testToId()
107107
*/
108108
public function testBadToId()
109109
{
110-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
110+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
111111
$builder->convertToId('non-existent-id');
112112
}
113113

114114
public function testGetAll()
115115
{
116-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
116+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
117117

118118
/** @var $all Civility[] */
119119
$all = $builder->getAll();
@@ -130,7 +130,7 @@ public function testGetAll()
130130

131131
public function testGetAllTwice()
132132
{
133-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
133+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
134134

135135
$all1 = $builder->getAll();
136136
$all2 = $builder->getAll();
@@ -140,7 +140,7 @@ public function testGetAllTwice()
140140

141141
public function testGetAssoc()
142142
{
143-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
143+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
144144
$assoc = $builder->getAssociative('name');
145145

146146
$this->assertArrayHasKey('mr', $assoc);
@@ -160,7 +160,7 @@ public function testGetAssoc()
160160

161161
public function testIs()
162162
{
163-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
163+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
164164

165165
/** @var $civility Civility */
166166
$civility = $builder->get('mr');
@@ -171,7 +171,7 @@ public function testIs()
171171

172172
public function testGetIds()
173173
{
174-
$builder = new StaticEntityBuilder('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
174+
$builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
175175
$ids = $builder->getIds();
176176

177177
$this->assertEquals(array('mr', 'mrs'), $ids);

0 commit comments

Comments
 (0)