From 78661bc205461c61dce8122a73f4049095b877da Mon Sep 17 00:00:00 2001 From: Adeline09 Date: Wed, 30 Aug 2023 12:45:37 -0400 Subject: [PATCH 1/4] solves + of non-matching type --- src/fib.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fib.ts b/src/fib.ts index 0d292e9..42f5fd8 100644 --- a/src/fib.ts +++ b/src/fib.ts @@ -8,5 +8,5 @@ export default function fibonacci(n) { return 1; } - return fibonacci(n - 1) + fibonacci(n - 2); + return (fibonacci(n - 1) + fibonacci(n - 2)); } From 0406fdda388df515e0efb87df8719b655a2762b3 Mon Sep 17 00:00:00 2001 From: Adeline09 Date: Thu, 31 Aug 2023 01:14:51 -0400 Subject: [PATCH 2/4] fixed error --- src/fib.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/fib.ts b/src/fib.ts index 42f5fd8..401944b 100644 --- a/src/fib.ts +++ b/src/fib.ts @@ -1,12 +1,14 @@ // util function that computes the fibonacci numbers -export default function fibonacci(n) { - if (n < 0) { +export default function fibonacci(n: number) { + if (n < 0) return -1; - } else if (n == 0) { + else if (n == 0) { return 0; } else if (n == 1) { return 1; } - return (fibonacci(n - 1) + fibonacci(n - 2)); + return fibonacci(n - 1) + fibonacci(n - 2); } + + From d9e56fb167b025f801a490660e215aba1ec76040 Mon Sep 17 00:00:00 2001 From: Adeline09 Date: Thu, 31 Aug 2023 17:43:33 -0400 Subject: [PATCH 3/4] fixed fibRoute --- src/fibRoute.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/fibRoute.ts b/src/fibRoute.ts index e4fa96e..3a49df3 100644 --- a/src/fibRoute.ts +++ b/src/fibRoute.ts @@ -1,5 +1,6 @@ // Endpoint for querying the fibonacci numbers +import * as express from 'express'; import fibonacci from "./fib"; export default (req, res) => { From 646d5531391f23c84fb21d0d8131cb3714c48d34 Mon Sep 17 00:00:00 2001 From: Adeline09 Date: Thu, 31 Aug 2023 18:09:12 -0400 Subject: [PATCH 4/4] fixed all errors --- src/fib.ts | 2 +- src/fibRoute.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/fib.ts b/src/fib.ts index 401944b..b060f7c 100644 --- a/src/fib.ts +++ b/src/fib.ts @@ -1,5 +1,5 @@ // util function that computes the fibonacci numbers -export default function fibonacci(n: number) { +export default function fibonacci(n: number):number { if (n < 0) return -1; else if (n == 0) { diff --git a/src/fibRoute.ts b/src/fibRoute.ts index 3a49df3..0c24099 100644 --- a/src/fibRoute.ts +++ b/src/fibRoute.ts @@ -1,9 +1,10 @@ // Endpoint for querying the fibonacci numbers import * as express from 'express'; +import {Request, Response} from 'express'; import fibonacci from "./fib"; -export default (req, res) => { +export default (req: Request, res: Response) => { const { num } = req.params; const fibN = fibonacci(parseInt(num));