PHP notices in logs can mask real errors - patch attached

[GoogleCodeExporter]

What steps will reproduce the problem?
1.  Run latest Webanywhere from Subversion.
2.  Look at your PHP/Apache error log.
3.

What is the expected output?
    The expected output is no warnings/notices in the logs.

What do you see instead?
    [22-Aug-2010 14:11:13] PHP Notice:  Use of undefined constant debug - assumed 'debug' in /Applications/MAMP/htdocs/wa/index.php on line 267
    [22-Aug-2010 14:11:13] PHP Notice:  Undefined index:  debug in /Applications/MAMP/htdocs/wa/index.php on line 267
...

What version of the product are you using? On what operating system?
    Revision 310. (osx 10.6)

Please provide any additional information below.
    I attach a patch to fix index.php and browser.php

    I'm impressed by the way WA works out of the box. Keep up the great work!
Thanks,
Nick Freear (@nfreear)

Original issue reported on code.google.com by n.d.freear on 22 Aug 2010 at 11:40

Attachments:

• patch-wa-phpwarn-22aug10.diff

[GoogleCodeExporter]

The patch still might trigger the "Undefined index" errors in the log. Each 
call to the variable should first check to see if it exists first. i.e.:
  if (isset($_REQUEST['debug']) && $_REQUEST['debug']==='true') ...

Original comment by smur...@gmail.com on 24 Mar 2011 at 10:14