From 48e5f4ef173cbbb4e258c1ae744c5e405f5b88fe Mon Sep 17 00:00:00 2001 From: Christophe Veaux Date: Mon, 3 Sep 2018 14:33:04 +0100 Subject: [PATCH 1/3] Update model.py Correct BLSTM implementation in keras_lib --- src/keras_lib/model.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/keras_lib/model.py b/src/keras_lib/model.py index 173137d6..baae93e0 100644 --- a/src/keras_lib/model.py +++ b/src/keras_lib/model.py @@ -134,12 +134,12 @@ def define_sequence_model(self): units=self.hidden_layer_size[i], input_shape=(None, input_size), return_sequences=True)) - elif self.hidden_layer_type[i]=='blstm': - self.model.add(LSTM( + elif self.hidden_layer_type[i] == 'blstm': + self.model.add(Bidirectional(LSTM( units=self.hidden_layer_size[i], - input_shape=(None, input_size), - return_sequences=True, - go_backwards=True)) + return_sequences=True), + input_shape=(None, input_size), + merge_mode='concat')) else: self.model.add(Dense( units=self.hidden_layer_size[i], From 4e4f90995df0778fd2d5d92994c266ed0e683e17 Mon Sep 17 00:00:00 2001 From: Christophe Veaux Date: Mon, 3 Sep 2018 14:46:34 +0100 Subject: [PATCH 2/3] Update model.py Correct BLSTM implementation in keras_lib --- src/keras_lib/model.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/keras_lib/model.py b/src/keras_lib/model.py index baae93e0..7d1fb392 100644 --- a/src/keras_lib/model.py +++ b/src/keras_lib/model.py @@ -185,6 +185,14 @@ def define_stateful_model(self, batch_size=25, seq_length=200): return_sequences=True, stateful=True, go_backwards=True)) + + elif self.hidden_layer_type[i] == 'blstm': + self.model.add(Bidirectional(LSTM( + units=self.hidden_layer_size[i], + return_sequences=True, + stateful=True), + batch_input_shape=(batch_size, timesteps, input_size), + merge_mode='concat')) else: self.model.add(Dense( units=self.hidden_layer_size[i], From 64de17cbdd9026e3fa51546c6341e1767d3b6157 Mon Sep 17 00:00:00 2001 From: Christophe Veaux Date: Mon, 3 Sep 2018 14:52:37 +0100 Subject: [PATCH 3/3] Update model.py Correct BSLTM implementation in keras_lib --- src/keras_lib/model.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/keras_lib/model.py b/src/keras_lib/model.py index 7d1fb392..11941400 100644 --- a/src/keras_lib/model.py +++ b/src/keras_lib/model.py @@ -178,14 +178,6 @@ def define_stateful_model(self, batch_size=25, seq_length=200): batch_input_shape=(batch_size, timesteps, input_size), return_sequences=True, stateful=True)) #go_backwards=True)) - elif self.hidden_layer_type[i]=='blstm': - self.model.add(LSTM( - units=self.hidden_layer_size[i], - batch_input_shape=(batch_size, timesteps, input_size), - return_sequences=True, - stateful=True, - go_backwards=True)) - elif self.hidden_layer_type[i] == 'blstm': self.model.add(Bidirectional(LSTM( units=self.hidden_layer_size[i],