buildRouteCollection() may fail if wrong value is already present in cache

[bancer]

    protected function buildRouteCollection(): RouteCollection
    {
    ...
                return Cache::remember(static::ROUTE_COLLECTION_CACHE_KEY, function () {
                    return $this->prepareRouteCollection();
                }, $this->cacheConfig);

This fails with PHP type error if the cache contains for example false value. Probably should be something like this:

                $cached = Cache::remember(static::ROUTE_COLLECTION_CACHE_KEY, function () {
                    return $this->prepareRouteCollection();
                }, $this->cacheConfig);
                if ($cached instance of RouteCollection) {
                    return $cached;
                } else {
                    Cache::delete(static::ROUTE_COLLECTION_CACHE_KEY, $this->cacheConfig);
                }

[steinkel]

The prepareRouteCollection() method returns RouteCollection so it should either fail due to an exception, or a type error. Please could you provide more details about when the false result is generated? I'd like to understand what's the root cause.

Thanks,

[bancer]

Yes, but Cache::remember(...) does not necessarily returns RouteCollection.

Maybe call something like Cache::write(static::ROUTE_COLLECTION_CACHE_KEY, false, $this->cacheConfig) before buildRouteCollection().

I've got that error while migrating from one CakePHP version to another.

[steinkel]

closed per #5