Address a bunch of warnings

CalcProgrammer1 · CalcProgrammer1 · commit 03d99d135c9f · 2022-08-31T19:16:57.000-05:00
diff --git a/Controllers/ASRockPolychromeUSBController/ASRockPolychromeUSBController.h b/Controllers/ASRockPolychromeUSBController/ASRockPolychromeUSBController.h
@@ -58,7 +58,7 @@ enum
     POLYCHROME_USB_ZONE_UNAVAILABLE         = 0x1E,     // Value from LEDCOUNT CFG if zone not present
 };
 
-static const char* polychrome_USB_zone_names[] =
+const char* polychrome_USB_zone_names[] =
 {
     "RGB LED 1 Header",
     "RGB LED 2 Header",
diff --git a/Controllers/AlienwareKeyboardController/AlienwareAW510KController.cpp b/Controllers/AlienwareKeyboardController/AlienwareAW510KController.cpp
@@ -172,7 +172,7 @@ void AlienwareAW510KController::SendInitialize()
 
 void AlienwareAW510KController::SetDirect
     (
-    unsigned char   zone,
+    unsigned char   /*zone*/,
     unsigned char   r,
     unsigned char   g,
     unsigned char   b
@@ -222,7 +222,7 @@ void AlienwareAW510KController::SendDirectOn
     | To Guarantee the data are always %4 =0 append   |
     | zeros at end of last packet                     |
     \*-----------------------------------------------*/
-    for(int i = 0; i < (frame_data.size() % 4); i++)
+    for(unsigned int i = 0; i < (frame_data.size() % 4); i++)
     {
         SelectedKeys key;
         key.idx     = 0x00;
@@ -358,7 +358,7 @@ void AlienwareAW510KController::UpdateSingleLED
 }
 void AlienwareAW510KController::SendMode
     (
-    unsigned char   zone,
+    unsigned char   /*zone*/,
     unsigned char   mode,
     unsigned short  speed,
     unsigned char   direction,
diff --git a/Controllers/AlienwareKeyboardController/RGBController_AlienwareAW510K.cpp b/Controllers/AlienwareKeyboardController/RGBController_AlienwareAW510K.cpp
@@ -395,7 +395,7 @@ void RGBController_AlienwareAW510K::DeviceUpdateLEDs()
 
 void RGBController_AlienwareAW510K::UpdateZoneLEDs(int zone)
 {
-    controller->SetDirect((unsigned char) zone, RGBGetRValue(zones[zone].colors[0]), RGBGetGValue(zones[zone].colors[0]), RGBGetBValue(zones[zone].colors[0]));
+    controller->SetDirect( RGBGetRValue(zones[zone].colors[0]), RGBGetGValue(zones[zone].colors[0]), RGBGetBValue(zones[zone].colors[0]));
 }
 
 void RGBController_AlienwareAW510K::UpdateSingleLED(int led)
diff --git a/Controllers/AsusAuraCoreController/AsusAuraCoreControllerDetect.cpp b/Controllers/AsusAuraCoreController/AsusAuraCoreControllerDetect.cpp
@@ -17,7 +17,7 @@
 *                                                                                          *
 \******************************************************************************************/
 
-void DetectAsusAuraCoreControllers(hid_device_info* info, const std::string&)
+void DetectAsusAuraCoreControllers(hid_device_info* info, const std::string& /*name*/)
 {
     hid_device* dev = hid_open_path(info->path);
 
@@ -37,7 +37,7 @@ void DetectAsusAuraCoreControllers(hid_device_info* info, const std::string&)
     }
 }
 
-void DetectAsusAuraCoreLaptopControllers(hid_device_info* info, const std::string& name)
+void DetectAsusAuraCoreLaptopControllers(hid_device_info* info, const std::string& /*name*/)
 {
     hid_device* dev = hid_open_path(info->path);
 
diff --git a/Controllers/AsusAuraUSBController/AsusAuraMousematController.cpp b/Controllers/AsusAuraUSBController/AsusAuraMousematController.cpp
@@ -110,7 +110,7 @@ void AuraMousematController::UpdateDevice
     usb_buf[0x08]   = pattern;
     usb_buf[0x09]   = 0x00;
 
-    for(int i = 0; i < colors.size(); i++)
+    for(unsigned int i = 0; i < colors.size(); i++)
     {
         usb_buf[0x0a + i * 3]   = RGBGetRValue(colors[i]);
         usb_buf[0x0b + i * 3]   = RGBGetGValue(colors[i]);
diff --git a/Controllers/AsusAuraUSBController/AsusAuraRyuoAIOController.cpp b/Controllers/AsusAuraUSBController/AsusAuraRyuoAIOController.cpp
@@ -33,7 +33,7 @@ std::string AsusAuraRyuoAIOController::GetLocation()
 	return("HID: " + location);
 }
 
-void AsusAuraRyuoAIOController::SetMode(unsigned char channel, unsigned char mode, unsigned char red, unsigned char grn, unsigned char blu)
+void AsusAuraRyuoAIOController::SetMode(unsigned char /*channel*/, unsigned char /*mode*/, unsigned char /*red*/, unsigned char /*grn*/, unsigned char /*blu*/)
 {
 	/*---------------------------------------------------------*\
 	| This interface is not used in this controller however is  |
@@ -56,7 +56,7 @@ void AsusAuraRyuoAIOController::SetMode(unsigned char mode, unsigned char speed,
 	}
 }
 
-void AsusAuraRyuoAIOController::SetChannelLEDs(unsigned char channel, RGBColor * colors, unsigned int num_colors)
+void AsusAuraRyuoAIOController::SetChannelLEDs(unsigned char /*channel*/, RGBColor* /*colors*/, unsigned int /*num_colors*/)
 {
 	/*---------------------------------------------------------*\
 	| This interface is not used in this controller however is  |
diff --git a/Controllers/AsusAuraUSBController/RGBController_AsusAuraRyuoAIO.cpp b/Controllers/AsusAuraUSBController/RGBController_AsusAuraRyuoAIO.cpp
@@ -169,7 +169,7 @@ void RGBController_AsusAuraRyuoAIO::SetupZones()
     SetupColors();
 }
 
-void RGBController_AsusAuraRyuoAIO::ResizeZone(int zone, int new_size)
+void RGBController_AsusAuraRyuoAIO::ResizeZone(int /*zone*/, int /*new_size*/)
 {
     /*---------------------------------------------------------*\
     | This device does not support resizing zones               |
diff --git a/Controllers/AsusAuraUSBController/RGBController_ROGStrixLC_Controller.cpp b/Controllers/AsusAuraUSBController/RGBController_ROGStrixLC_Controller.cpp
@@ -171,7 +171,7 @@ void RGBController_ROGStrixLC_Controller::SetupZones()
     SetupColors();
 }
 
-void RGBController_ROGStrixLC_Controller::ResizeZone(int zone, int new_size)
+void RGBController_ROGStrixLC_Controller::ResizeZone(int /*zone*/, int /*new_size*/)
 {
     /*---------------------------------------------------------*\
     | This device does not support resizing zones               |
diff --git a/Controllers/AsusAuraUSBController/ROGStrixLC_Controller.cpp b/Controllers/AsusAuraUSBController/ROGStrixLC_Controller.cpp
@@ -34,7 +34,7 @@ std::string ROGStrixLC_Controller::GetLocation()
     return("HID: " + location);
 }
 
-void ROGStrixLC_Controller::SetMode(unsigned char channel, unsigned char mode, unsigned char red, unsigned char grn, unsigned char blu)
+void ROGStrixLC_Controller::SetMode(unsigned char /*channel*/, unsigned char /*mode*/, unsigned char /*red*/, unsigned char /*grn*/, unsigned char /*blu*/)
 {
     /*---------------------------------------------------------*\
     | This interface is not used in this controller however is  |
@@ -58,7 +58,7 @@ void ROGStrixLC_Controller::SetMode(unsigned char mode, unsigned char speed, uns
     }
 }
 
-void ROGStrixLC_Controller::SetChannelLEDs(unsigned char channel, RGBColor * colors, unsigned int num_colors)
+void ROGStrixLC_Controller::SetChannelLEDs(unsigned char /*channel*/, RGBColor* /*colors*/, unsigned int /*num_colors*/)
 {
     /*---------------------------------------------------------*\
     | This interface is not used in this controller however is  |
diff --git a/qt/OpenRGBDialog2.cpp b/qt/OpenRGBDialog2.cpp
@@ -1348,7 +1348,7 @@ void OpenRGBDialog2::UpdateDevicesList()
         | Remove all remaining device information tabs, leaving |
         | other information tabs alone                          |
         \*-----------------------------------------------------*/
-        for(std::size_t tab_idx = controllers.size(); tab_idx < ui->InformationTabBar->count(); tab_idx++)
+        for(int tab_idx = controllers.size(); tab_idx < ui->InformationTabBar->count(); tab_idx++)
         {
             std::string type_str = ui->InformationTabBar->widget(base_tab)->metaObject()->className();
             if(type_str == "Ui::OpenRGBDeviceInfoPage")
diff --git a/qt/OpenRGBNanoleafSettingsPage/OpenRGBNanoleafScanningThread.cpp b/qt/OpenRGBNanoleafSettingsPage/OpenRGBNanoleafScanningThread.cpp
diff --git a/super_io/super_io.cpp b/super_io/super_io.cpp

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ enum`
`58`	`58`	`POLYCHROME_USB_ZONE_UNAVAILABLE = 0x1E, // Value from LEDCOUNT CFG if zone not present`
`59`	`59`	`};`
`60`	`60`
`61`		`-static const char* polychrome_USB_zone_names[] =`
	`61`	`+const char* polychrome_USB_zone_names[] =`
`62`	`62`	`{`
`63`	`63`	`"RGB LED 1 Header",`
`64`	`64`	`"RGB LED 2 Header",`
Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ void AlienwareAW510KController::SendInitialize()`
`172`	`172`
`173`	`173`	`void AlienwareAW510KController::SetDirect`
`174`	`174`	`(`
`175`		`- unsigned char zone,`
	`175`	`+ unsigned char /zone/,`
`176`	`176`	`unsigned char r,`
`177`	`177`	`unsigned char g,`
`178`	`178`	`unsigned char b`
`@@ -222,7 +222,7 @@ void AlienwareAW510KController::SendDirectOn`
`222`	`222`	`\| To Guarantee the data are always %4 =0 append \|`
`223`	`223`	`\| zeros at end of last packet \|`
`224`	`224`	`\-----------------------------------------------/`
`225`		`- for(int i = 0; i < (frame_data.size() % 4); i++)`
	`225`	`+ for(unsigned int i = 0; i < (frame_data.size() % 4); i++)`
`226`	`226`	`{`
`227`	`227`	`SelectedKeys key;`
`228`	`228`	`key.idx = 0x00;`
`@@ -358,7 +358,7 @@ void AlienwareAW510KController::UpdateSingleLED`
`358`	`358`	`}`
`359`	`359`	`void AlienwareAW510KController::SendMode`
`360`	`360`	`(`
`361`		`- unsigned char zone,`
	`361`	`+ unsigned char /zone/,`
`362`	`362`	`unsigned char mode,`
`363`	`363`	`unsigned short speed,`
`364`	`364`	`unsigned char direction,`
Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,7 @@ void RGBController_AlienwareAW510K::DeviceUpdateLEDs()`
`395`	`395`
`396`	`396`	`void RGBController_AlienwareAW510K::UpdateZoneLEDs(int zone)`
`397`	`397`	`{`
`398`		`- controller->SetDirect((unsigned char) zone, RGBGetRValue(zones[zone].colors[0]), RGBGetGValue(zones[zone].colors[0]), RGBGetBValue(zones[zone].colors[0]));`
	`398`	`+ controller->SetDirect( RGBGetRValue(zones[zone].colors[0]), RGBGetGValue(zones[zone].colors[0]), RGBGetBValue(zones[zone].colors[0]));`
`399`	`399`	`}`
`400`	`400`
`401`	`401`	`void RGBController_AlienwareAW510K::UpdateSingleLED(int led)`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`* *`
`18`	`18`	`\******************************************************************************************/`
`19`	`19`
`20`		`-void DetectAsusAuraCoreControllers(hid_device_info* info, const std::string&)`
	`20`	`+void DetectAsusAuraCoreControllers(hid_device_info* info, const std::string& /name/)`
`21`	`21`	`{`
`22`	`22`	`hid_device* dev = hid_open_path(info->path);`
`23`	`23`
`@@ -37,7 +37,7 @@ void DetectAsusAuraCoreControllers(hid_device_info* info, const std::string&)`
`37`	`37`	`}`
`38`	`38`	`}`
`39`	`39`
`40`		`-void DetectAsusAuraCoreLaptopControllers(hid_device_info* info, const std::string& name)`
	`40`	`+void DetectAsusAuraCoreLaptopControllers(hid_device_info* info, const std::string& /name/)`
`41`	`41`	`{`
`42`	`42`	`hid_device* dev = hid_open_path(info->path);`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ void AuraMousematController::UpdateDevice`
`110`	`110`	`usb_buf[0x08] = pattern;`
`111`	`111`	`usb_buf[0x09] = 0x00;`
`112`	`112`
`113`		`- for(int i = 0; i < colors.size(); i++)`
	`113`	`+ for(unsigned int i = 0; i < colors.size(); i++)`
`114`	`114`	`{`
`115`	`115`	`usb_buf[0x0a + i * 3] = RGBGetRValue(colors[i]);`
`116`	`116`	`usb_buf[0x0b + i * 3] = RGBGetGValue(colors[i]);`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ std::string AsusAuraRyuoAIOController::GetLocation()`
`33`	`33`	`return("HID: " + location);`
`34`	`34`	`}`
`35`	`35`
`36`		`-void AsusAuraRyuoAIOController::SetMode(unsigned char channel, unsigned char mode, unsigned char red, unsigned char grn, unsigned char blu)`
	`36`	`+void AsusAuraRyuoAIOController::SetMode(unsigned char /channel/, unsigned char /mode/, unsigned char /red/, unsigned char /grn/, unsigned char /blu/)`
`37`	`37`	`{`
`38`	`38`	`/---------------------------------------------------------\`
`39`	`39`	`\| This interface is not used in this controller however is \|`
`@@ -56,7 +56,7 @@ void AsusAuraRyuoAIOController::SetMode(unsigned char mode, unsigned char speed,`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`
`59`		`-void AsusAuraRyuoAIOController::SetChannelLEDs(unsigned char channel, RGBColor * colors, unsigned int num_colors)`
	`59`	`+void AsusAuraRyuoAIOController::SetChannelLEDs(unsigned char /channel/, RGBColor* /colors/, unsigned int /num_colors/)`
`60`	`60`	`{`
`61`	`61`	`/---------------------------------------------------------\`
`62`	`62`	`\| This interface is not used in this controller however is \|`
Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ void RGBController_AsusAuraRyuoAIO::SetupZones()`
`169`	`169`	`SetupColors();`
`170`	`170`	`}`
`171`	`171`
`172`		`-void RGBController_AsusAuraRyuoAIO::ResizeZone(int zone, int new_size)`
	`172`	`+void RGBController_AsusAuraRyuoAIO::ResizeZone(int /zone/, int /new_size/)`
`173`	`173`	`{`
`174`	`174`	`/---------------------------------------------------------\`
`175`	`175`	`\| This device does not support resizing zones \|`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ void RGBController_ROGStrixLC_Controller::SetupZones()`
`171`	`171`	`SetupColors();`
`172`	`172`	`}`
`173`	`173`
`174`		`-void RGBController_ROGStrixLC_Controller::ResizeZone(int zone, int new_size)`
	`174`	`+void RGBController_ROGStrixLC_Controller::ResizeZone(int /zone/, int /new_size/)`
`175`	`175`	`{`
`176`	`176`	`/---------------------------------------------------------\`
`177`	`177`	`\| This device does not support resizing zones \|`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ std::string ROGStrixLC_Controller::GetLocation()`
`34`	`34`	`return("HID: " + location);`
`35`	`35`	`}`
`36`	`36`
`37`		`-void ROGStrixLC_Controller::SetMode(unsigned char channel, unsigned char mode, unsigned char red, unsigned char grn, unsigned char blu)`
	`37`	`+void ROGStrixLC_Controller::SetMode(unsigned char /channel/, unsigned char /mode/, unsigned char /red/, unsigned char /grn/, unsigned char /blu/)`
`38`	`38`	`{`
`39`	`39`	`/---------------------------------------------------------\`
`40`	`40`	`\| This interface is not used in this controller however is \|`
`@@ -58,7 +58,7 @@ void ROGStrixLC_Controller::SetMode(unsigned char mode, unsigned char speed, uns`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
`61`		`-void ROGStrixLC_Controller::SetChannelLEDs(unsigned char channel, RGBColor * colors, unsigned int num_colors)`
	`61`	`+void ROGStrixLC_Controller::SetChannelLEDs(unsigned char /channel/, RGBColor* /colors/, unsigned int /num_colors/)`
`62`	`62`	`{`
`63`	`63`	`/---------------------------------------------------------\`
`64`	`64`	`\| This interface is not used in this controller however is \|`
Original file line number	Diff line number	Diff line change
`@@ -1348,7 +1348,7 @@ void OpenRGBDialog2::UpdateDevicesList()`
`1348`	`1348`	`\| Remove all remaining device information tabs, leaving \|`
`1349`	`1349`	`\| other information tabs alone \|`
`1350`	`1350`	`\-----------------------------------------------------/`
`1351`		`- for(std::size_t tab_idx = controllers.size(); tab_idx < ui->InformationTabBar->count(); tab_idx++)`
	`1351`	`+ for(int tab_idx = controllers.size(); tab_idx < ui->InformationTabBar->count(); tab_idx++)`
`1352`	`1352`	`{`
`1353`	`1353`	`std::string type_str = ui->InformationTabBar->widget(base_tab)->metaObject()->className();`
`1354`	`1354`	`if(type_str == "Ui::OpenRGBDeviceInfoPage")`