Skip to content

Composer extensions skip post-installation processing #36

@tosfos

Description

@tosfos

Describe the bug

Summary: Extensions installed via Composer skip all post-installation processing including patches, additional steps, and persistent directories.

This is a bug in the code for #9.

Description: When an extension is configured with composer-name in its YAML configuration, the extensions-skins.php script installs it via Composer but then immediately exits the loop with continue. This prevents the extension from receiving any post-installation steps such as:

  • Patches
  • Additional steps
  • Persistent directories

This may not be urgent because no RR extensions currently use the composer-name field. But it does affect users who extend the yaml and it should be easy enough to solve.

My guess is that this continue line was there because without that it will try to do a git clone which will fail. The solution is probably to change that if statement to something like if ( !$bundled **&& !isset( $data['composer-name'] )** ).

Steps to reproduce the behavior:

Look at lines 45-50

Expected behavior

Composer-installed extensions should receive the same post-installation processing as git-cloned extensions, including patches, additional steps, and persistent directories handling. The continue statement should be removed to allow consistent processing regardless of installation method.

System info

All (infrastructure issue)

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions