Skip to content

Commit dd81ef4

Browse files
committed
[CoreBundle] Fix down migrations by removing IF EXISTS, not a valid MySQL 8 statements - related to pimcore#15787
1 parent de564ab commit dd81ef4

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

bundles/CoreBundle/Migrations/Version20220119082511.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,22 @@ public function up(Schema $schema): void
6666

6767
public function down(Schema $schema): void
6868
{
69-
if ($schema->getTable('gridconfig_favourites')->hasIndex('grid_config_id')) {
70-
$this->addSql('ALTER TABLE `gridconfig_favourites` DROP INDEX IF EXISTS `grid_config_id`;');
71-
}
72-
7369
if ($schema->getTable('gridconfig_favourites')->hasForeignKey('fk_gridconfig_favourites_gridconfigs')) {
74-
$this->addSql('ALTER TABLE `gridconfig_favourites` DROP FOREIGN KEY IF EXISTS `fk_gridconfig_favourites_gridconfigs`;');
70+
$this->addSql('ALTER TABLE `gridconfig_favourites` DROP FOREIGN KEY `fk_gridconfig_favourites_gridconfigs`;');
7571
}
7672

7773
$this->addSql('ALTER TABLE `gridconfig_favourites` CHANGE `gridConfigId` `gridConfigId` int(11) NULL;');
7874

79-
if ($schema->getTable('gridconfig_shares')->hasIndex('grid_config_id')) {
80-
$this->addSql('ALTER TABLE `gridconfig_shares` DROP INDEX IF EXISTS `grid_config_id`;');
75+
if ($schema->getTable('gridconfig_shares')->hasForeignKey('fk_gridconfig_favourites_gridconfigs')) {
76+
$this->addSql('ALTER TABLE `gridconfig_shares` DROP FOREIGN KEY `fk_gridconfig_shares_gridconfigs`;');
8177
}
8278

83-
if ($schema->getTable('gridconfig_shares')->hasForeignKey('fk_gridconfig_favourites_gridconfigs')) {
84-
$this->addSql('ALTER TABLE `gridconfig_shares` DROP FOREIGN KEY IF EXISTS `fk_gridconfig_shares_gridconfigs`;');
79+
if ($schema->getTable('gridconfig_favourites')->hasIndex('grid_config_id')) {
80+
$this->addSql('ALTER TABLE `gridconfig_favourites` DROP INDEX `grid_config_id`;');
81+
}
82+
83+
if ($schema->getTable('gridconfig_shares')->hasIndex('grid_config_id')) {
84+
$this->addSql('ALTER TABLE `gridconfig_shares` DROP INDEX `grid_config_id`;');
8585
}
8686
}
8787
}

bundles/CoreBundle/Migrations/Version20220120121803.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,12 @@ public function down(Schema $schema): void
8787
{
8888
foreach (['documents_hardlink', 'documents_link', 'documents_page', 'documents_snippet', 'documents_printpage', 'documents_email', 'email_log', 'documents_newsletter', 'documents_editables', 'documents_translations'] as $table) {
8989
if ($schema->getTable($table)->hasForeignKey('fk_'.$table.'_documents')) {
90-
$this->addSql('ALTER TABLE `'.$table.'` DROP FOREIGN KEY IF EXISTS `fk_'.$table.'_documents`;');
90+
$this->addSql('ALTER TABLE `'.$table.'` DROP FOREIGN KEY `fk_'.$table.'_documents`;');
9191
}
9292
}
9393

9494
if ($schema->getTable('sites')->hasForeignKey('fk_sites_documents')) {
95-
$this->addSql('ALTER TABLE `sites` DROP FOREIGN KEY IF EXISTS `fk_sites_documents`;');
95+
$this->addSql('ALTER TABLE `sites` DROP FOREIGN KEY `fk_sites_documents`;');
9696
}
9797
}
9898
}

bundles/CoreBundle/Migrations/Version20220120162621.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,11 @@ public function down(Schema $schema): void
121121
{
122122
foreach (['asset', 'document', 'object'] as $elementType) {
123123
if ($schema->getTable('users_workspaces_'.$elementType)->hasForeignKey('fk_users_workspaces_'.$elementType.'_'.$elementType.'s')) {
124-
$this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` DROP FOREIGN KEY IF EXISTS `fk_users_workspaces_'.$elementType.'_'.$elementType.'s`');
124+
$this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` DROP FOREIGN KEY `fk_users_workspaces_'.$elementType.'_'.$elementType.'s`');
125125
}
126126

127127
if ($schema->getTable('users_workspaces_'.$elementType)->hasForeignKey('fk_users_workspaces_'.$elementType.'_users')) {
128-
$this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` DROP FOREIGN KEY IF EXISTS `fk_users_workspaces_'.$elementType.'_users`');
128+
$this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` DROP FOREIGN KEY `fk_users_workspaces_'.$elementType.'_users`');
129129
}
130130

131131
$this->addSql('ALTER TABLE `users_workspaces_'.$elementType.'` CHANGE `userId` `userId` int(11) NOT NULL DEFAULT \'0\'');

0 commit comments

Comments
 (0)