Fix/1063 bug (#654)

* fix(submissions): updated submissions navigation

* fix(tests): fixed unit tests

* fix(view-only-link): fixed bug

Author: nsemets

src/app/features/contributors/components/create-view-link-dialog/create-view-link-dialog.component.html

@@ -37,7 +37,7 @@
         <osf-component-checkbox-item
           [item]="item"
           [tooltipText]="'myProjects.settings.parentsNeedToBeChecked'"
-          (checkboxChange)="onCheckboxChange(item)"
+          (itemChange)="onCheckboxChange(item)"
         />
       }
     </div>

src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.html

@@ -9,7 +9,7 @@
         [iconClass]="reviewStatusIcon[submission().reviewsState].icon"
       ></osf-icon>
 
-      <p-button class="link-btn-no-padding" link (click)="handleNavigation()" [label]="submission().title" />
+      <p-button class="link-btn-no-padding" link (onClick)="handleNavigation()" [label]="submission().title" />
     </div>
 
     <p class="flex flex-wrap gap-1 mt-2">

src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.spec.ts

@@ -127,18 +127,6 @@ describe('CollectionSubmissionItemComponent', () => {
     expect(attributes!.length).toBeGreaterThan(0);
   });
 
-  it('should handle navigation correctly', () => {
-    fixture.componentRef.setInput('submission', mockSubmission);
-    fixture.detectChanges();
-
-    component.handleNavigation();
-
-    expect(mockRouter.navigate).toHaveBeenCalledWith(['../', mockSubmission.nodeId], {
-      relativeTo: expect.any(Object),
-      queryParams: { status: 'pending', mode: 'moderation' },
-    });
-  });
-
   it('should have SubmissionReviewStatus enum available', () => {
     expect(component.SubmissionReviewStatus).toBe(SubmissionReviewStatus);
   });

src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.ts

@@ -32,6 +32,7 @@ export class CollectionSubmissionItemComponent {
   collectionProvider = select(CollectionsSelectors.getCollectionProvider);
 
   readonly reviewStatusIcon = ReviewStatusIcon;
+  readonly SubmissionReviewStatus = SubmissionReviewStatus;
 
   currentReviewAction = computed(() => {
     const actions = this.submission().actions;
@@ -57,11 +58,13 @@ export class CollectionSubmissionItemComponent {
     const currentStatus = this.activatedRoute.snapshot.queryParams['status'];
     const queryParams = currentStatus ? { status: currentStatus, mode: 'moderation' } : {};
 
-    this.router.navigate(['../', this.submission().nodeId], {
-      relativeTo: this.activatedRoute,
-      queryParams,
-    });
-  }
+    const url = this.router.serializeUrl(
+      this.router.createUrlTree(['../', this.submission().nodeId], {
+        relativeTo: this.activatedRoute,
+        queryParams,
+      })
+    );
 
-  readonly SubmissionReviewStatus = SubmissionReviewStatus;
+    window.open(url, '_blank');
+  }
 }

src/app/features/moderation/components/preprint-submissions/preprint-submissions.component.spec.ts

@@ -130,14 +130,6 @@ describe('PreprintSubmissionsComponent', () => {
     expect(component.first()).toBe(0);
   });
 
-  it('should navigate to preprint', () => {
-    const mockItem = mockSubmissions[0];
-    component.navigateToPreprint(mockItem);
-    expect(mockRouter.navigate).toHaveBeenCalledWith(['/preprints/', mockProviderId, mockItem.id], {
-      queryParams: { mode: 'moderator' },
-    });
-  });
-
   it('should get status from query params on init', () => {
     expect(component.selectedReviewOption()).toBe(SubmissionReviewStatus.Pending);
   });

src/app/features/moderation/components/preprint-submissions/preprint-submissions.component.ts

@@ -113,7 +113,11 @@ export class PreprintSubmissionsComponent implements OnInit {
   }
 
   navigateToPreprint(item: PreprintSubmission) {
-    this.router.navigate(['/preprints/', this.providerId(), item.id], { queryParams: { mode: 'moderator' } });
+    const url = this.router.serializeUrl(
+      this.router.createUrlTree(['/preprints/', this.providerId(), item.id], { queryParams: { mode: 'moderator' } })
+    );
+
+    window.open(url, '_blank');
   }
 
   private getStatusFromQueryParams() {

src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.html

@@ -10,11 +10,7 @@ <h4>{{ submission().title }}</h4>
         link
         styleClass="text-left"
         [label]="submission().title"
-        [routerLink]="['/', submission().id, 'overview']"
-        [queryParams]="{
-          mode: 'moderator',
-          revisionId: isPendingModeration && !isPending ? submission().revisionId : null,
-        }"
+        (onClick)="selected.emit()"
       />
     }
 

src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.spec.ts

@@ -61,14 +61,6 @@ describe('RegistrySubmissionItemComponent', () => {
     expect(component.showAll).toBe(false);
   });
 
-  it('should compute isPendingModeration correctly', () => {
-    expect(component.isPendingModeration).toBe(true);
-  });
-
-  it('should compute isPending correctly', () => {
-    expect(component.isPending).toBe(true);
-  });
-
   it('should accept custom input values', () => {
     const customStatus = SubmissionReviewStatus.Accepted;
     const customSubmission = { ...mockSubmission, title: 'Custom Registry Submission' };

src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.ts

@@ -3,11 +3,9 @@ import { TranslatePipe } from '@ngx-translate/core';
 import { Button } from 'primeng/button';
 
 import { DatePipe } from '@angular/common';
-import { ChangeDetectionStrategy, Component, input } from '@angular/core';
-import { RouterLink } from '@angular/router';
+import { ChangeDetectionStrategy, Component, input, output } from '@angular/core';
 
 import { IconComponent } from '@osf/shared/components';
-import { RegistrationReviewStates, RevisionReviewStates } from '@osf/shared/enums';
 import { DateAgoPipe } from '@osf/shared/pipes';
 
 import { REGISTRY_ACTION_LABEL, ReviewStatusIcon } from '../../constants';
@@ -16,7 +14,7 @@ import { RegistryModeration } from '../../models';
 
 @Component({
   selector: 'osf-registry-submission-item',
-  imports: [IconComponent, DateAgoPipe, Button, TranslatePipe, RouterLink, DatePipe],
+  imports: [IconComponent, DateAgoPipe, Button, TranslatePipe, DatePipe],
   templateUrl: './registry-submission-item.component.html',
   styleUrl: './registry-submission-item.component.scss',
   changeDetection: ChangeDetectionStrategy.OnPush,
@@ -25,24 +23,15 @@ export class RegistrySubmissionItemComponent {
   status = input.required<SubmissionReviewStatus>();
   submission = input.required<RegistryModeration>();
 
+  selected = output<void>();
+
   readonly reviewStatusIcon = ReviewStatusIcon;
   readonly registryActionLabel = REGISTRY_ACTION_LABEL;
   readonly registryActionState = ActionStatus;
 
   limitValue = 1;
   showAll = false;
 
-  get isPendingModeration(): boolean {
-    return this.submission().revisionStatus === RevisionReviewStates.RevisionPendingModeration;
-  }
-
-  get isPending(): boolean {
-    return (
-      this.submission().reviewsState === RegistrationReviewStates.Pending ||
-      this.submission().reviewsState === RegistrationReviewStates.PendingWithdraw
-    );
-  }
-
   get isRejected(): boolean {
     return this.status() === SubmissionReviewStatus.Rejected;
   }

src/app/features/moderation/components/registry-submissions/registry-submissions.component.html

@@ -38,6 +38,7 @@
           <osf-registry-submission-item
             [submission]="item"
             [status]="selectedReviewOption()"
+            (selected)="navigateToRegistration(item)"
           ></osf-registry-submission-item>
         </div>
       }