Merge branch 'fix/performance-improvements' of https://github.com/nsemets/angular-osf into fix/performance-improvements

Author: nsemets

src/app/features/moderation/components/moderators-list/moderators-list.component.spec.ts

@@ -5,15 +5,16 @@ import { of } from 'rxjs';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { ActivatedRoute } from '@angular/router';
 
+import { ProviderSelectors } from '@core/store/provider';
 import { UserSelectors } from '@core/store/user';
-import { ModeratorsTableComponent } from '@osf/features/moderation/components';
+import { SearchInputComponent } from '@osf/shared/components';
 import { ResourceType } from '@osf/shared/enums';
-import { SearchInputComponent } from '@shared/components';
 import { CustomConfirmationService, CustomDialogService } from '@shared/services';
 
 import { ModeratorPermission } from '../../enums';
 import { ModeratorModel } from '../../models';
 import { ModeratorsSelectors } from '../../store/moderators';
+import { ModeratorsTableComponent } from '../moderators-table/moderators-table.component';
 
 import { ModeratorsListComponent } from './moderators-list.component';
 
@@ -71,6 +72,7 @@ describe('ModeratorsListComponent', () => {
           signals: [
             { selector: UserSelectors.getCurrentUser, value: mockCurrentUser },
             { selector: ModeratorsSelectors.getModerators, value: mockModerators },
+            { selector: ProviderSelectors.hasAdminAccess, value: false },
             { selector: ModeratorsSelectors.isModeratorsLoading, value: false },
           ],
         }),
@@ -110,7 +112,7 @@ describe('ModeratorsListComponent', () => {
 
     fixture.detectChanges();
 
-    expect(component.isCurrentUserAdminModerator()).toBe(false);
+    expect(component.hasAdminAccess()).toBe(false);
   });
 
   it('should return false for admin moderator when user is not found', () => {
@@ -121,7 +123,7 @@ describe('ModeratorsListComponent', () => {
 
     fixture.detectChanges();
 
-    expect(component.isCurrentUserAdminModerator()).toBe(false);
+    expect(component.hasAdminAccess()).toBe(false);
   });
 
   it('should load moderators on initialization', () => {

src/app/features/moderation/components/moderators-table/moderators-table.component.spec.ts

@@ -44,7 +44,7 @@ describe('ModeratorsTableComponent', () => {
 
     fixture.componentRef.setInput('tableParams', mockTableParams);
     fixture.componentRef.setInput('currentUserId', 'test-user-id');
-    fixture.componentRef.setInput('isCurrentUserAdminModerator', false);
+    fixture.componentRef.setInput('hasAdminAccess', false);
   });
 
   it('should create', () => {
@@ -56,15 +56,15 @@ describe('ModeratorsTableComponent', () => {
     fixture.componentRef.setInput('items', mockModerators);
     fixture.componentRef.setInput('isLoading', true);
     fixture.componentRef.setInput('currentUserId', 'current-user-123');
-    fixture.componentRef.setInput('isCurrentUserAdminModerator', true);
+    fixture.componentRef.setInput('hasAdminAccess', true);
     fixture.componentRef.setInput('tableParams', mockTableParams);
 
     fixture.detectChanges();
 
     expect(component.items()).toEqual(mockModerators);
     expect(component.isLoading()).toBe(true);
     expect(component.currentUserId()).toBe('current-user-123');
-    expect(component.isCurrentUserAdminModerator()).toBe(true);
+    expect(component.hasAdminAccess()).toBe(true);
     expect(component.tableParams()).toEqual(mockTableParams);
   });
 
@@ -118,7 +118,7 @@ describe('ModeratorsTableComponent', () => {
     fixture.componentRef.setInput('items', []);
     fixture.componentRef.setInput('tableParams', mockTableParams);
     fixture.componentRef.setInput('currentUserId', 'test-user-id');
-    fixture.componentRef.setInput('isCurrentUserAdminModerator', false);
+    fixture.componentRef.setInput('hasAdminAccess', false);
 
     fixture.detectChanges();
 
@@ -128,7 +128,7 @@ describe('ModeratorsTableComponent', () => {
   it('should handle undefined currentUserId', () => {
     fixture.componentRef.setInput('currentUserId', undefined);
     fixture.componentRef.setInput('tableParams', mockTableParams);
-    fixture.componentRef.setInput('isCurrentUserAdminModerator', false);
+    fixture.componentRef.setInput('hasAdminAccess', false);
 
     fixture.detectChanges();
 

src/app/features/profile/components/profile-information/profile-information.component.spec.ts

@@ -156,15 +156,6 @@ describe('ProfileInformationComponent', () => {
     expect(socials).toEqual([]);
   });
 
-  it('should not include profileWebsites in social links', () => {
-    fixture.componentRef.setInput('currentUser', mockUser);
-    fixture.detectChanges();
-
-    const socials = component.userSocials();
-    const websites = socials.filter((s) => s.alt === 'settings.profileSettings.social.labels.profileWebsites');
-    expect(websites.length).toBe(0);
-  });
-
   it('should emit editProfile event when called', (done) => {
     component.editProfile.subscribe(() => {
       expect(true).toBe(true);