FIX - If navigating directly to a preprints, registries, or institutions, or profile discovery page, the entire OSF corpus is listed as results #657 (#658)

* fix(global-search): Normalize quotes in search text, fixed search section init on the profile page

* fix(global-search): Fixed search section init on the profile page

Author: rrromchIk

src/app/features/institutions/pages/institutions-search/institutions-search.component.html

@@ -20,6 +20,8 @@ <h1>{{ institution().name }}</h1>
       <p [innerHtml]="institution().description | safeHtml"></p>
     </div>
 
-    <osf-global-search [resourceTabOptions]="resourceTabOptions" />
+    @if (defaultSearchFiltersInitialized()) {
+      <osf-global-search [resourceTabOptions]="resourceTabOptions" />
+    }
   }
 </section>

src/app/features/institutions/pages/institutions-search/institutions-search.component.ts

@@ -3,7 +3,7 @@ import { createDispatchMap, select } from '@ngxs/store';
 import { SafeHtmlPipe } from 'primeng/menu';
 
 import { NgOptimizedImage } from '@angular/common';
-import { ChangeDetectionStrategy, Component, inject, OnInit } from '@angular/core';
+import { ChangeDetectionStrategy, Component, inject, OnInit, signal } from '@angular/core';
 import { FormsModule } from '@angular/forms';
 import { ActivatedRoute } from '@angular/router';
 
@@ -29,6 +29,7 @@ export class InstitutionsSearchComponent implements OnInit {
 
   institution = select(InstitutionsSearchSelectors.getInstitution);
   isInstitutionLoading = select(InstitutionsSearchSelectors.getInstitutionLoading);
+  defaultSearchFiltersInitialized = signal<boolean>(false);
 
   readonly resourceTabOptions = SEARCH_TAB_OPTIONS;
 
@@ -41,6 +42,7 @@ export class InstitutionsSearchComponent implements OnInit {
             'affiliation,isContainedBy.affiliation',
             this.institution().iris.join(',')
           );
+          this.defaultSearchFiltersInitialized.set(true);
         },
       });
     }

src/app/features/preprints/pages/preprint-provider-discover/preprint-provider-discover.component.html

@@ -4,6 +4,6 @@
   [isPreprintProviderLoading]="isPreprintProviderLoading()"
 />
 
-@if (preprintProvider()) {
+@if (defaultSearchFiltersInitialized()) {
   <osf-global-search [searchControlInput]="searchControl" [provider]="preprintProvider() ?? null" />
 }

src/app/features/preprints/pages/preprint-provider-discover/preprint-provider-discover.component.ts

@@ -1,6 +1,6 @@
 import { createDispatchMap, select } from '@ngxs/store';
 
-import { ChangeDetectionStrategy, Component, HostBinding, inject, OnDestroy, OnInit } from '@angular/core';
+import { ChangeDetectionStrategy, Component, HostBinding, inject, OnDestroy, OnInit, signal } from '@angular/core';
 import { FormControl } from '@angular/forms';
 import { ActivatedRoute } from '@angular/router';
 
@@ -37,6 +37,7 @@ export class PreprintProviderDiscoverComponent implements OnInit, OnDestroy {
   isPreprintProviderLoading = select(PreprintProvidersSelectors.isPreprintProviderDetailsLoading);
 
   searchControl = new FormControl('');
+  defaultSearchFiltersInitialized = signal<boolean>(false);
 
   ngOnInit() {
     this.actions.getPreprintProviderById(this.providerId).subscribe({
@@ -46,6 +47,7 @@ export class PreprintProviderDiscoverComponent implements OnInit, OnDestroy {
         if (provider) {
           this.actions.setDefaultFilterValue('publisher', provider.iri);
           this.actions.setResourceType(ResourceType.Preprint);
+          this.defaultSearchFiltersInitialized.set(true);
 
           BrandService.applyBranding(provider.brand);
           HeaderStyleHelper.applyHeaderStyles(

src/app/features/profile/profile.component.ts

@@ -66,16 +66,16 @@ export class ProfileComponent implements OnInit {
   private setupMyProfile(user: UserModel): void {
     this.actions.setUserProfile(user);
     if (user?.iri) {
-      this.defaultSearchFiltersInitialized.set(true);
       this.actions.setDefaultFilterValue('creator,isContainedBy.creator', user.iri);
+      this.defaultSearchFiltersInitialized.set(true);
     }
   }
 
   private setSearchFilter(): void {
     const currentUser = this.user();
     if (currentUser?.iri) {
-      this.defaultSearchFiltersInitialized.set(true);
       this.actions.setDefaultFilterValue('creator,isContainedBy.creator', currentUser.iri);
+      this.defaultSearchFiltersInitialized.set(true);
     }
   }
 }

src/app/features/registries/pages/registries-provider-search/registries-provider-search.component.html

@@ -4,6 +4,6 @@
   [isProviderLoading]="isProviderLoading()"
 />
 
-@if (provider()) {
+@if (defaultSearchFiltersInitialized()) {
   <osf-global-search [searchControlInput]="searchControl" />
 }

src/app/features/registries/pages/registries-provider-search/registries-provider-search.component.ts

@@ -1,6 +1,6 @@
 import { createDispatchMap, select } from '@ngxs/store';
 
-import { ChangeDetectionStrategy, Component, inject, OnDestroy, OnInit } from '@angular/core';
+import { ChangeDetectionStrategy, Component, inject, OnDestroy, OnInit, signal } from '@angular/core';
 import { FormControl } from '@angular/forms';
 import { ActivatedRoute } from '@angular/router';
 
@@ -36,6 +36,7 @@ export class RegistriesProviderSearchComponent implements OnInit, OnDestroy {
 
   provider = select(RegistrationProviderSelectors.getBrandedProvider);
   isProviderLoading = select(RegistrationProviderSelectors.isBrandedProviderLoading);
+  defaultSearchFiltersInitialized = signal<boolean>(false);
 
   searchControl = new FormControl('');
 
@@ -46,6 +47,7 @@ export class RegistriesProviderSearchComponent implements OnInit, OnDestroy {
         next: () => {
           this.actions.setDefaultFilterValue('publisher', this.provider()!.iri!);
           this.actions.setResourceType(ResourceType.Registration);
+          this.defaultSearchFiltersInitialized.set(true);
         },
       });
     }