Skip to content

Commit 6e3195b

Browse files
authored
Merge pull request #12937 from CesiumGS/sandcastle-banner-update
Sandcastle full release
2 parents 89eee79 + 74c943d commit 6e3195b

File tree

8 files changed

+33
-17
lines changed

8 files changed

+33
-17
lines changed

.github/workflows/prod.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
name: prod
2-
on:
2+
on:
33
push:
4-
branches:
5-
- 'cesium.com'
4+
branches:
5+
- "cesium.com"
66
jobs:
77
lint:
88
runs-on: ubuntu-latest
@@ -11,7 +11,7 @@ jobs:
1111
- name: install node 22
1212
uses: actions/setup-node@v5
1313
with:
14-
node-version: '22'
14+
node-version: "22"
1515
- name: npm install
1616
run: npm install
1717
- name: lint *.js
@@ -36,13 +36,17 @@ jobs:
3636
- name: install node 22
3737
uses: actions/setup-node@v5
3838
with:
39-
node-version: '22'
39+
node-version: "22"
4040
- name: npm install
4141
run: npm install
4242
- name: build website release
4343
run: npm run website-release
4444
- name: build apps
4545
run: npm run build-apps
46+
- name: build types
47+
run: npm run build-ts
48+
- name: build prod sandcastle
49+
run: npm run build-prod -w packages/sandcastle -- -l warn
4650
- name: deploy to cesium.com
4751
if: ${{ env.AWS_ACCESS_KEY_ID != '' }}
4852
run: |
@@ -51,4 +55,4 @@ jobs:
5155
aws s3 sync Build/release/ s3://cesium-website/cesiumjs/releases/$(cat package.json | jq -r '.version' | sed 's/\.0$//')/ --cache-control "public, max-age=1800" --delete
5256
aws s3 sync Build/Documentation/ s3://cesium-website/cesiumjs/ref-doc/ --cache-control "public, max-age=1800" --delete
5357
aws s3 sync Build/CesiumViewer/ s3://cesium-website/cesiumjs/cesium-viewer/ --cache-control "public, max-age=1800" --delete
54-
aws s3 sync Build/Sandcastle/ s3://cesium-sandcastle-website/ --cache-control "public, max-age=1800" --delete
58+
aws s3 sync Build/Sandcastle2/ s3://cesium-sandcastle-website/ --cache-control "public, max-age=1800" --delete

Apps/Sandcastle/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
data-dojo-type="dijit.layout.ContentPane"
8282
data-dojo-props="region: 'top'"
8383
>
84-
<a href="https://dev-sandcastle.cesium.com"
84+
<a href="https://sandcastle.cesium.com"
8585
>Try the new version of Sandcastle today!</a
8686
>
8787
</div>

CHANGES.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## 1.134 - 2025-10-01
44

5+
- [Sandcastle](https://sandcastle.cesium.com/) has been updated at `https://sandcastle.cesium.com`! The [legacy Sandcastle app](https://cesium.com/downloads/cesiumjs/releases/1.134/Apps/Sandcastle/index.html) will remain available through November 3, 2025.
6+
57
### @cesium/engine
68

79
#### Fixes :wrench:

gulpfile.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -447,6 +447,13 @@ export const websiteRelease = gulp.series(
447447
node: false,
448448
});
449449
},
450+
function () {
451+
return buildCesium({
452+
minify: true,
453+
removePragmas: true,
454+
node: false,
455+
});
456+
},
450457
combineForSandcastle,
451458
buildDocs,
452459
);
@@ -663,6 +670,7 @@ export const makeZip = gulp.series(release, async function createZipFile() {
663670
"!**/*.gitignore",
664671
"!Specs/e2e/*-snapshots/**",
665672
"!Apps/Sandcastle/gallery/development/**",
673+
"!Apps/Sandcastle2/**",
666674
],
667675
{
668676
encoding: false,

index.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,11 @@
3232
<a href="Apps/HelloWorld.html">Hello World</a>
3333
</li>
3434
<li>
35-
<a href="Apps/Sandcastle/index.html">Sandcastle</a>
35+
<a href="Apps/Sandcastle2/index.html">Sandcastle</a>
3636
<ul>
3737
<li>
38-
<a href="Build/Apps/Sandcastle/index.html">Built Sandcastle</a>
38+
<a href="Apps/Sandcastle/index.html">Legacy Sandcastle</a>
3939
</li>
40-
<li><a href="Apps/Sandcastle2/index.html">Sandcastle v2</a></li>
4140
</ul>
4241
</li>
4342
<li>

packages/sandcastle/sandcastle.config.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import process from "process";
2+
13
const config = {
24
root: ".",
35
sourceUrl: "https://github.com/CesiumGS/cesium/blob/main/packages/sandcastle",
@@ -19,7 +21,7 @@ const config = {
1921
labels: [],
2022
development: false,
2123
},
22-
includeDevelopment: true,
24+
includeDevelopment: !process.env.PROD,
2325
},
2426
};
2527

packages/sandcastle/src/App.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,10 @@ function App() {
483483
synchronizeColorScheme
484484
>
485485
<div className="banner">
486-
<Anchor href="https://sandcastle.cesium.com" tone="accent">
486+
<Anchor
487+
href="https://cesium.com/downloads/cesiumjs/releases/1.134/Apps/Sandcastle/index.html"
488+
tone="accent"
489+
>
487490
Looking for the old Sandcastle? It's still here (for a little while) →
488491
</Anchor>
489492
</div>

packages/sandcastle/src/Gallery/Gallery.css

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,9 @@
126126
padding: var(--stratakit-space-x2);
127127
gap: var(--stratakit-space-x2);
128128
overflow-y: auto;
129-
&:focus-visible {
130-
/* small margin to allow focus highlight to be visible all the way around */
131-
margin: 0 3px 4px;
132-
border-radius: var(--stratakit-ext-radius-xs);
133-
}
129+
/* small margin to allow focus highlight to be visible all the way around */
130+
margin: 0 3px 4px;
131+
border-radius: var(--stratakit-ext-radius-xs);
134132
}
135133

136134
.empty-list div {

0 commit comments

Comments
 (0)