Skip to content

Upgrade AES to use nodejs builtins #200

@acolytec3

Description

@acolytec3

discv5 currently uses the bcrypto implementation of the AES ciphers and this can relatively painlessly be switched to use the nodejs builtin equivalents. This work was already done in #197 and should be easily pulled out into a standalone PR and appeared to provide a modest performance improvement at the same time.

Node builtins
✔ benchmark aes cipher encryption/decryptions 23322.53 ops/s 42.87700 us/op - 2322 runs 0.101 s

With bcrypto
✔ benchmark aes cipher encryption/decryptions 21194.07 ops/s 47.18300 us/op - 2137 runs 0.102 s

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions