Skip to content

1. Crash when g.u == 0xf0150, 2. "textual run -c textual colors" - erresc #5

@aofitserov

Description

@aofitserov
  1. Crash when g.u > 0xffff (?!), possible fix the following:
diff --git a/qlightterminal.cpp b/qlightterminal.cpp
index a6a594f..1e1860d 100644
--- a/qlightterminal.cpp
+++ b/qlightterminal.cpp
@@ -259,7 +259,12 @@ void QLightTerminal::paintEvent(QPaintEvent *event) {
painter.setFont(font);
}

-            line += QChar(g.u);
+            if (0xffff < g.u) {
+                for (auto c: QStringView(QChar::fromUcs4(g.u)))
+                    line += QChar(c);
+            } else {
+                line += QChar(g.u);
+            }
}
painter.drawText(QPointF(offset, yPos), line);
yPos -= win.lineheight;
  1. "textual run -c textual colors" - mouse doesn't work. WTF? textual
erresc: unknown csi ESC[>1u
erresc: unknown csi ESC[=1;u
erresc: unknown csi ESC[?2026$p

After Ctrl+C:

erresc: unknown csi ESC[<u

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions