Skip to content

Conversation

cx-rah-pid
Copy link
Contributor

@cx-rah-pid cx-rah-pid commented Aug 29, 2025

By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.

Description

Updated the list of excluded engine types for the Visual Studio agent.
Added\ Updated unit tests related to this.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Related Issues

Fixed below issues -
https://checkmarx.atlassian.net/browse/AST-111544 - CLI | Remove filterScsResultsByAgent in CLI and update unit\integration tests accordingly
https://checkmarx.atlassian.net/browse/AST-113072 - CLI | Create scan is ot working for scs scan in resubmit case

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the CLI help for new/changed functionality in this PR (if applicable)
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

Screenshots (if applicable)

Add screenshots to help explain your changes.

Test Cases

Case 1:

  • Create a new project (Project1) on the CxOne portal and run a scan without selecting the scs (secret detection) scan type.
  • Wait for the scan to complete.
  • Run a new scan using the following command (ensure required details are updated):
    cx scan create --scan-info-format json -s C:\Newfolder\JavaVulnerableLab --project-name Project1 --branch master --agent "Visual Studio" --async --sast-incremental --resubmit
  • Wait for the scan to complete.
  • Expected Result : The SCS scan will be skipped.

Case 2:

  • Create a new project (Project2) on the CxOne portal and run a scan with the scs (secret detection) scan type enabled.
  • Wait for the scan to complete.
  • Run a new scan using the following command (ensure required details are updated):
    cx scan create --scan-info-format json -s C:\Newfolder\JavaVulnerableLab --project-name Project2 --branch master --agent "Visual Studio" --async --sast-incremental --resubmit
  • Wait for the scan to complete.
  • Expected Result: The SCS scan will be executed.

Case 3:

  • Generate a JSON scan report for Project1 using the following command (ensure required details are updated):
    cx results show --scan-id 73a67f6e-1470-4829-981d-02a8ff9e5097 --report-format json --output-name 8c118ee6-a880-4817-a0e1-51367eb9ce10 --output-path C:\Users\RahulP\AppData\Local\Temp1 --agent "Visual Studio"
  • Expected Result: No SCS results will be generated.

Case 4:

  • Generate a JSON scan report for Project2 using the following command (ensure required details are updated):
    cx results show --scan-id 73a67f6e-1470-4829-981d-02a8ff9e5097 --report-format json --output-name 8c118ee6-a880-4817-a0e1-51367eb9ce10 --output-path C:\Users\RahulP\AppData\Local\Temp1 --agent "Visual Studio"
  • Expected Result: SCS results will be generated.

@cx-rah-pid cx-rah-pid changed the title modified excluded engine type for agent Visual Studio (AST-110820) Modified excluded engine type for agent Visual Studio (AST-110820) Aug 29, 2025
Copy link

github-actions bot commented Sep 10, 2025

Logo
Checkmarx One – Scan Summary & Details6206beaf-91a1-49f7-8551-b3589e70c6cc

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Collaborator

@cx-anurag-dalke cx-anurag-dalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants