New code in 0.9.16 causing issues with some mos

[gomoore]

This line

imcsdk/imcsdk/imchandle.py

Line 745 in de830ff

if all([isinstance(mo, CommVMediaMap), hasattr(mo, 'admin_action'), mo.admin_action == CommVMediaMapConsts.ADMIN_ACTION_SAVE_UNMAPPED_VOLUME]):

fails when processing LsbootBootSecurity mo when setting up boot options:

File "/usr/local/lib/python3.10/dist-packages/imcsdk/imchandle.py", line 745, in _get_mo_status
        if all([isinstance(mo, CommVMediaMap), hasattr(mo, 'admin_action'), mo.admin_action == CommVMediaMapConsts.ADMIN_ACTION_SAVE_UNMAPPED_VOLUME]):
    AttributeError: 'LsbootBootSecurity' object has no attribute 'admin_action'

[mikeslowik]

We have noticed the same and indeed changing that line to logical AND seems to fix it:

            if isinstance(mo, CommVMediaMap) and hasattr(mo, 'admin_action') and mo.admin_action == CommVMediaMapConsts.ADMIN_ACTION_SAVE_UNMAPPED_VOLUME:

[monykeo]

I think I may have had a similar issue with the admin_action attribute trying to call this function:

def _set_server_locator_led_state(handle, enabled, kwargs):
    server_dn = _set_server_dn(handle, kwargs)
    led_mo = EquipmentLocatorLed(parent_mo_or_dn=server_dn)
    led_mo.admin_state = (EquipmentLocatorLedConsts.ADMIN_STATE_OFF,
                          EquipmentLocatorLedConsts.ADMIN_STATE_ON)[enabled]
    handle.set_mo(led_mo)

It returns this:

Error turning on LED locator: 'EquipmentLocatorLed' object has no attribute 'admin_action'

[mikeslowik]

The root cause is the same - set_mo() method calls _get_mo_status() method before actually saving settings to CIMC (i.e. calling _commit() method).