Skip to content

bugfixes: initialize, SlabSeaIceThermodynamics#786

Merged
juliasloan25 merged 3 commits intomainfrom
js/fixes
Apr 29, 2026
Merged

bugfixes: initialize, SlabSeaIceThermodynamics#786
juliasloan25 merged 3 commits intomainfrom
js/fixes

Conversation

@juliasloan25
Copy link
Copy Markdown
Member

@juliasloan25 juliasloan25 commented Apr 28, 2026

This PR makes a few bug fixes:

  • Fix initialize call: This was incorrectly changed in remove initialization_update_state! #776 and is making CI fail on main
  • Rename some fields of SlabSeaIceThermodynamics - these were renamed in ClimaSeaIce v0.4.8 (PR). Since that wasn't a breaking release, ClimaOcean tries to use it and CI fails

@juliasloan25 juliasloan25 changed the title fix initialize call bugfixes Apr 29, 2026
@juliasloan25 juliasloan25 changed the title bugfixes bugfixes: initialize, SlabSeaIceThermodynamics Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.01%. Comparing base (980b28f) to head (6c83d57).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/SeaIces/sea_ice_simulation.jl 0.00% 3 Missing ⚠️
src/OceanSeaIceModels/ocean_sea_ice_model.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   18.80%   18.01%   -0.80%     
==========================================
  Files          63       63              
  Lines        3531     3531              
==========================================
- Hits          664      636      -28     
- Misses       2867     2895      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliasloan25 juliasloan25 merged commit f6d5b0f into main Apr 29, 2026
27 of 30 checks passed
@juliasloan25 juliasloan25 deleted the js/fixes branch April 29, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants