fix: Better backwards compatibility for app url (#104)

Author: teeohhem

.changeset/witty-jobs-deliver.md

@@ -0,0 +1,5 @@
+---
+"helm-charts": patch
+---
+
+fix: Better backwards compatibility for app url for existing deployments

charts/hdx-oss-v2/tests/configmap_test.yaml

@@ -41,3 +41,88 @@ tests:
       - matchRegex:
           path: data.MONGO_URI
           pattern: mongodb://.*-mongodb:27017/hyperdx
+
+  - it: should use default frontendUrl template with appUrl and appPort
+    set:
+      hyperdx:
+        apiPort: 8000
+        appPort: 3000
+        appUrl: "http://localhost"
+        # frontendUrl should default to {{ .Values.hyperdx.appUrl }}:{{ .Values.hyperdx.appPort }}
+      mongodb:
+        port: 27017
+    asserts:
+      - equal:
+          path: data.FRONTEND_URL
+          value: "http://localhost:3000"
+
+  - it: should override frontendUrl when explicitly set
+    set:
+      hyperdx:
+        apiPort: 8000
+        appPort: 3000
+        appUrl: "http://localhost"
+        frontendUrl: "https://my-custom-domain.com"
+      mongodb:
+        port: 27017
+    asserts:
+      - equal:
+          path: data.FRONTEND_URL
+          value: "https://my-custom-domain.com"
+
+  - it: should support template expressions in frontendUrl
+    set:
+      hyperdx:
+        apiPort: 8000
+        appPort: 4000
+        appUrl: "https://production-host"
+        frontendUrl: "{{ .Values.hyperdx.appUrl }}:{{ .Values.hyperdx.appPort }}/app"
+      mongodb:
+        port: 27017
+    asserts:
+      - equal:
+          path: data.FRONTEND_URL
+          value: "https://production-host:4000/app"
+
+  - it: should handle custom appUrl and appPort in default frontendUrl
+    set:
+      hyperdx:
+        apiPort: 8000
+        appPort: 4000
+        appUrl: "https://staging.example.com"
+        # Using default frontendUrl template
+      mongodb:
+        port: 27017
+    asserts:
+      - equal:
+          path: data.FRONTEND_URL
+          value: "https://staging.example.com:4000"
+
+  - it: should work with ingress-style URLs in frontendUrl
+    set:
+      hyperdx:
+        apiPort: 8000
+        appPort: 3000
+        appUrl: "http://localhost"
+        frontendUrl: "https://hyperdx.example.com"
+      mongodb:
+        port: 27017
+    asserts:
+      - equal:
+          path: data.FRONTEND_URL
+          value: "https://hyperdx.example.com"
+
+  - it: should support complex template expressions
+    set:
+      hyperdx:
+        apiPort: 8000
+        appPort: 3000
+        appUrl: "http://localhost"
+        frontendUrl: "{{ if eq .Values.env \"production\" }}https://prod.example.com{{ else }}{{ .Values.hyperdx.appUrl }}:{{ .Values.hyperdx.appPort }}{{ end }}"
+      env: "development"
+      mongodb:
+        port: 27017
+    asserts:
+      - equal:
+          path: data.FRONTEND_URL
+          value: "http://localhost:3000"

charts/hdx-oss-v2/values.yaml

@@ -43,9 +43,11 @@ hyperdx:
   apiPort: 8000
   appPort: 3000
   opampPort: 4320
-  # The URL that will be use to access the frontend. Defaults to the http://localhost:appPort.
+  # deprecated: use frontendUrl instead
+  appUrl: "http://localhost"
+  # The URL that will be use to access the frontend. Defaults to the http://localhost:3000.
   # If you have an ingress enabled, you should set this to the ingress host with the protocol. E.g. https://hdx-my-domain.com
-  frontendUrl: http://localhost:{{ .Values.hyperdx.appPort }}
+  frontendUrl: "{{ .Values.hyperdx.appUrl }}:{{ .Values.hyperdx.appPort }}"
   logLevel: "info"
   usageStatsEnabled: true
   # Endpoint to send hyperdx logs/traces/metrics to.Defaults to the chart's otel collector endpoint.