From 73ac105f938a552f42dc37208c6bcf30d812729f Mon Sep 17 00:00:00 2001 From: Simon Prykhodko Date: Sun, 7 Nov 2021 19:53:22 +0100 Subject: [PATCH 1/2] Uncomment normal addition --- Src_CC_wrap/PoissonReconLib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Src_CC_wrap/PoissonReconLib.cpp b/Src_CC_wrap/PoissonReconLib.cpp index a2486cfc..20492f01 100644 --- a/Src_CC_wrap/PoissonReconLib.cpp +++ b/Src_CC_wrap/PoissonReconLib.cpp @@ -369,7 +369,7 @@ void ExtractMesh( const PoissonReconLib::Parameters& params, out_mesh.addVertex(v.point.coords); if (sampleData) { - //out_mesh.addNormal(v.normal); + out_mesh.addNormal(v.normal); out_mesh.addColor(v.color); } if (params.density) From 40f2c86f75a2d202276fe6559c738d8089cdedad Mon Sep 17 00:00:00 2001 From: Simon Prykhodko Date: Mon, 6 Dec 2021 21:19:48 +0100 Subject: [PATCH 2/2] Don't use multithreading for Aarch64 See https://github.com/mkazhdan/PoissonRecon/issues/190#issuecomment-922378290. --- Src_CC_wrap/PoissonReconLib.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Src_CC_wrap/PoissonReconLib.cpp b/Src_CC_wrap/PoissonReconLib.cpp index 20492f01..26bfe282 100644 --- a/Src_CC_wrap/PoissonReconLib.cpp +++ b/Src_CC_wrap/PoissonReconLib.cpp @@ -715,6 +715,8 @@ bool PoissonReconLib::Reconstruct( const Parameters& params, #ifdef WITH_OPENMP ThreadPool::Init((ThreadPool::ParallelType)(int)ThreadPool::OPEN_MP, std::thread::hardware_concurrency()); +#elif defined __aarch64__ // See https://github.com/mkazhdan/PoissonRecon/issues/190#issuecomment-922378290. + ThreadPool::Init((ThreadPool::ParallelType)(int)ThreadPool::NONE, std::thread::hardware_concurrency()); #else ThreadPool::Init((ThreadPool::ParallelType)(int)ThreadPool::THREAD_POOL, std::thread::hardware_concurrency()); #endif @@ -759,6 +761,8 @@ bool PoissonReconLib::Reconstruct( const Parameters& params, #ifdef WITH_OPENMP ThreadPool::Init((ThreadPool::ParallelType)(int)ThreadPool::OPEN_MP, std::thread::hardware_concurrency()); +#elif defined __aarch64__ // See https://github.com/mkazhdan/PoissonRecon/issues/190#issuecomment-922378290. + ThreadPool::Init((ThreadPool::ParallelType)(int)ThreadPool::NONE, std::thread::hardware_concurrency()); #else ThreadPool::Init((ThreadPool::ParallelType)(int)ThreadPool::THREAD_POOL, std::thread::hardware_concurrency()); #endif