Remove unused TransactionListener

Author: majecty

core/src/miner/miner.rs

@@ -111,11 +111,8 @@ struct SealingWork {
     enabled: bool,
 }
 
-type TransactionListener = Box<dyn Fn(&[TxHash]) + Send + Sync>;
-
 pub struct Miner {
     mem_pool: Arc<RwLock<MemPool>>,
-    transaction_listener: RwLock<Vec<TransactionListener>>,
     next_allowed_reseal: Mutex<Instant>,
     next_mandatory_reseal: RwLock<Instant>,
     sealing_block_last_request: Mutex<u64>,
@@ -173,7 +170,6 @@ impl Miner {
 
         Self {
             mem_pool,
-            transaction_listener: RwLock::new(vec![]),
             next_allowed_reseal: Mutex::new(Instant::now()),
             next_mandatory_reseal: RwLock::new(Instant::now() + options.reseal_max_period),
             params: RwLock::new(AuthoringParams::default()),
@@ -196,11 +192,6 @@ impl Miner {
         self.mem_pool.write().recover_from_db(client);
     }
 
-    /// Set a callback to be notified about imported transactions' hashes.
-    pub fn add_transactions_listener(&self, f: Box<dyn Fn(&[TxHash]) + Send + Sync>) {
-        self.transaction_listener.write().push(f);
-    }
-
     /// Get `Some` `clone()` of the current pending block's state or `None` if we're not sealing.
     pub fn pending_state(&self, latest_block_number: BlockNumber) -> Option<TopLevelState> {
         self.map_pending_block(|b| b.state().clone(), latest_block_number)
@@ -355,7 +346,7 @@ impl Miner {
 
         debug_assert_eq!(insertion_results.len(), intermediate_results.iter().filter(|r| r.is_ok()).count());
         let mut insertion_results_index = 0;
-        let results = intermediate_results
+        intermediate_results
             .into_iter()
             .map(|res| match res {
                 Err(e) => Err(e),
@@ -367,13 +358,7 @@ impl Miner {
                     Ok(result)
                 }
             })
-            .collect();
-
-        for listener in &*self.transaction_listener.read() {
-            listener(&inserted);
-        }
-
-        results
+            .collect()
     }
 
     fn calculate_timelock<C: BlockChainTrait>(&self, tx: &SignedTransaction, client: &C) -> Result<TxTimelock, Error> {