Remove Reflection*::setAccessible() calls (#44)

* Enable native lazy objects whenever possible.

The LazyGhostTrait will be removed from symfony/var-exporter:8.

* Fix usage of deprecated phpstan config option

* setAccessible() has no effect as of PHP 8.1

Author: W0rma

phpstan.neon

@@ -8,7 +8,6 @@ parameters:
         - tests/data/doctrine_fixtures/TestFixture1.php
         - tests/data/doctrine_fixtures/TestFixture2.php
         - tests/_support/UnitTester.php
-  checkMissingIterableValueType: false
   reportUnmatchedIgnoredErrors: true
   ignoreErrors:
       - path: tests/
@@ -21,3 +20,4 @@ parameters:
         message: '#Method \S+ has no return type specified#'
       - path: tests/
         message: '#(?:Method|Property) .+ with generic (?:interface|class) \S+ does not specify its types#'
+      - identifier: missingType.iterableValue

src/Codeception/Module/Doctrine.php

@@ -299,7 +299,6 @@ protected function clean(): void
         $reflectedEm = new ReflectionClass($em);
         if ($reflectedEm->hasProperty('repositories')) {
             $property = $reflectedEm->getProperty('repositories');
-            $property->setAccessible(true);
             $property->setValue($em, []);
         }
         $this->em->clear();
@@ -401,13 +400,11 @@ public function haveFakeRepository(string $className, array $methods = []): void
             //Support doctrine versions before 2.4.0
 
             $property = $reflectedEm->getProperty('repositories');
-            $property->setAccessible(true);
             $property->setValue($em, array_merge($property->getValue($em), [$className => $mock]));
         } elseif ($reflectedEm->hasProperty('repositoryFactory')) {
             //For doctrine 2.4.0+ versions
 
             $repositoryFactoryProperty = $reflectedEm->getProperty('repositoryFactory');
-            $repositoryFactoryProperty->setAccessible(true);
             $repositoryFactory = $repositoryFactoryProperty->getValue($em);
 
             $reflectedRepositoryFactory = new ReflectionClass($repositoryFactory);
@@ -419,7 +416,6 @@ public function haveFakeRepository(string $className, array $methods = []): void
                 );
             } elseif ($reflectedRepositoryFactory->hasProperty('repositoryList')) {
                 $repositoryListProperty = $reflectedRepositoryFactory->getProperty('repositoryList');
-                $repositoryListProperty->setAccessible(true);
 
                 $repositoryHash = $em->getClassMetadata($className)->getName() . spl_object_id($em);
                 $repositoryListProperty->setValue(

src/Codeception/Util/ReflectionPropertyAccessor.php

@@ -25,7 +25,6 @@ public function getProperty(object $obj, string $field): mixed
             $reflectedEntity = new ReflectionClass($class);
             if ($reflectedEntity->hasProperty($field)) {
                 $property = $reflectedEntity->getProperty($field);
-                $property->setAccessible(true);
                 return $property->getValue($obj);
             }
             $class = get_parent_class($class);
@@ -62,7 +61,6 @@ private function setPropertiesForClass(?object $obj, string $class, array $data)
 
         foreach ($reflectedEntity->getProperties() as $property) {
             if (isset($data[$property->name])) {
-                $property->setAccessible(true);
                 $property->setValue($obj, $data[$property->name]);
             }
         }

tests/unit/Codeception/Module/Doctrine2Test.php

@@ -81,18 +81,18 @@ protected function _setUp()
         $connection = DriverManager::getConnection(['driver' => $sqliteDriver, 'memory' => true]);
 
         if (version_compare(InstalledVersions::getVersion('doctrine/orm'), '3', '>=')) {
-            $this->em = new EntityManager(
-                $connection,
-                ORMSetup::createAttributeMetadataConfiguration([$dir], true)
-            );
+            $configuration = ORMSetup::createAttributeMetadataConfiguration([$dir], true);
         } else {
-            $this->em = new EntityManager(
-                $connection,
-                // @phpstan-ignore-next-line
-                ORMSetup::createAnnotationMetadataConfiguration([$dir], true)
-            );
+            // @phpstan-ignore-next-line
+            $configuration = ORMSetup::createAnnotationMetadataConfiguration([$dir], true);
         }
 
+        if (PHP_VERSION_ID >= 80400 && method_exists($configuration, 'enableNativeLazyObjects')) {
+            $configuration->enableNativeLazyObjects(true);
+        }
+
+        $this->em = new EntityManager($connection, $configuration);
+
         (new SchemaTool($this->em))->createSchema([
             $this->em->getClassMetadata(CompositePrimaryKeyEntity::class),
             $this->em->getClassMetadata(PlainEntity::class),