Simplify codebase (#31)

Author: TavoNiievez

config/packages/dev/monolog.php

@@ -4,8 +4,7 @@
 
 use Symfony\Config\MonologConfig;
 
-return static function (MonologConfig $monolog): void
-{
+return static function (MonologConfig $monolog): void {
     $monolog->handler('main', [
         'type' => 'stream',
         'path' => '%kernel.logs_dir%/%kernel.environment%.log',

config/packages/prod/monolog.php

@@ -4,22 +4,21 @@
 
 use Symfony\Config\MonologConfig;
 
-return static function (MonologConfig $monolog): void
-{
+return static function (MonologConfig $monolog): void {
     $monolog->handler('main', [
         'type' => 'fingers_crossed',
         'action_level' => 'error',
         'handler' => 'nested',
-        'buffer_size' => 50
+        'buffer_size' => 50,
     ])->excludedHttpCode()->code(404)->code(405);
     $monolog->handler('nested', [
         'type' => 'stream',
         'path' => 'php://stderr',
         'level' => 'debug',
-        'formatter' => 'monolog.formatter.json'
+        'formatter' => 'monolog.formatter.json',
     ]);
     $monolog->handler('console', [
         'type' => 'console',
-        'process_psr_3_messages' => false
+        'process_psr_3_messages' => false,
     ])->channels()->elements(['!event', '!doctrine']);
 };

config/packages/security.php

@@ -7,8 +7,7 @@
 use Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface;
 use Symfony\Config\SecurityConfig;
 
-return static function (SecurityConfig $security): void
-{
+return static function (SecurityConfig $security): void {
     $security->enableAuthenticatorManager(true);
     $security->passwordHasher(PasswordAuthenticatedUserInterface::class, 'auto');
     $userProvider = $security->provider('app_user_provider');
@@ -32,6 +31,6 @@
     $mainFirewall->entryPoint('form_login');
 
     $security->accessControl([
-        'path' => '^/dashboard', 'roles' => 'ROLE_USER'
+        'path' => '^/dashboard', 'roles' => 'ROLE_USER',
     ]);
 };

config/packages/test/monolog.php

@@ -4,8 +4,7 @@
 
 use Symfony\Config\MonologConfig;
 
-return static function (MonologConfig $monolog): void
-{
+return static function (MonologConfig $monolog): void {
     $monolog->handler('main', [
         'type' => 'fingers_crossed',
         'action_level' => 'error',
@@ -14,6 +13,6 @@
     $monolog->handler('nested', [
         'type' => 'stream',
         'path' => '%kernel.logs_dir%/%kernel.environment%.log',
-        'level' => 'debug'
+        'level' => 'debug',
     ]);
 };

src/Command/ExampleCommand.php

@@ -32,13 +32,10 @@ protected function configure(): void
         );
     }
 
-    protected function initialize(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->ioStream = new SymfonyStyle($input, $output);
-    }
 
-    protected function execute(InputInterface $input, OutputInterface $output): int
-    {
         $optionSomething = $input->getOption(self::OPTION_SOMETHING);
         if ($optionSomething) {
             $this->ioStream->text('Bye world!');

src/Controller/HttpClientController.php

@@ -12,11 +12,8 @@
 
 final class HttpClientController extends AbstractController
 {
-    private HttpClientInterface $httpClient;
-
-    public function __construct(HttpClientInterface $httpClient)
+    public function __construct(private readonly HttpClientInterface $httpClient)
     {
-        $this->httpClient = $httpClient;
     }
 
     public function routeUsingHttpClient(): Response
@@ -65,9 +62,7 @@ public function routeMakingMultipleRequests(): Response
 
     public function internalEndpointPost(Request $request): Response
     {
-        $data = json_decode($request->getContent(), true);
-
-        return $this->json(['received' => $data]);
+        return $this->json(['received' => $request->toArray()]);
     }
 
     public function routeShouldNotMakeSpecificRequest(): Response

src/Controller/RegistrationController.php

@@ -19,7 +19,7 @@ final class RegistrationController extends AbstractController
     public function __construct(
         private readonly Mailer $mailer,
         private readonly UserRepositoryInterface $userRepository,
-        private readonly EventDispatcherInterface $eventDispatcher
+        private readonly EventDispatcherInterface $eventDispatcher,
     ) {
     }
 

src/Entity/User.php

@@ -40,6 +40,7 @@ public static function create(string $email, string $password, array $roles = []
         $user->email = $email;
         $user->password = $password;
         $user->roles = $roles;
+
         return $user;
     }
 

src/Repository/Model/UserRepositoryInterface.php

@@ -9,4 +9,4 @@ interface UserRepositoryInterface
     public function save(User $user): void;
 
     public function getByEmail(string $email): ?User;
-}
+}

src/Repository/UserRepository.php

@@ -27,6 +27,7 @@ public function getByEmail(string $email): ?User
     {
         /** @var User|null $user */
         $user = $this->findOneBy(['email' => $email]);
+
         return $user;
     }
 }