Skip to content

[BUG] victory combat status message remains visible on screen #19

@Codenix-1349

Description

@Codenix-1349

🐛 Bug Description

After finishing a combat encounter, the victory / end-of-combat status message remains visible on screen and cannot be dismissed manually.

The message stays persistent in the UI and does not disappear unless another game event triggers a new status update.

Actual behaviour:
The victory message remains displayed indefinitely until another action (e.g. jumping to a different star system) overwrites it.


✅ Expected Behaviour

The end-of-combat victory message should:

  • Either disappear automatically after a short delay
  • Or be dismissible via click
  • Or be properly cleared once combat state is resolved

The UI should not remain in a persistent post-combat state.


🔁 Steps to Reproduce

  1. Start a combat encounter.
  2. Defeat the enemy.
  3. Observe the victory / end-of-combat status message.
  4. Attempt to dismiss or close the message.
  5. Notice that the message remains visible.
  6. Jump to another star system → message disappears.

🎮 Game Context

  • Branch: main
  • Commit (if known): unknown
  • Godot Version: 4.x
  • OS: Windows
  • Build Version (if applicable): development build

📂 Affected System

  • UI
  • Combat
  • AI
  • GalaxyMap
  • Economy
  • Audio
  • Camera
  • Save/Load
  • Other:

⚠️ Severity

  • Low (Minor visual issue)
  • Medium (Gameplay affected, workaround exists)
  • High (Core system affected)
  • Critical (Game-breaking)

Reason:
A workaround exists (triggering a new status update, e.g. via jump), but the UI state is incorrect and can confuse the player.


📸 Screenshots / Logs

No error messages in console.
No crashes observed.


🧠 Additional Notes

Workaround:
The message disappears when triggering another status update (e.g. jumping to a new star system).

Possible causes:

  • Combat state cleanup does not reset/clear the status UI
  • Missing signal emission after combat resolution
  • Status label not cleared or overwritten
  • Victory message state persists until the next event overrides it

Likely related to combat state cleanup logic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingmediumAffects gameplay but workaround exists.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions