Merge branch '6310-sdk-negative-integers-in-settint-and-other-colour-setters-causes-a-crash' into 'master'

fix(sdk): invalid negative values for colours no longer crash the game

See merge request codingame/game-engine!211

Author: CodinGameCommunity

engine/modules/entities/src/main/resources/view/entity-module/errors/InvalidPlayerColorToken.js

@@ -0,0 +1,8 @@
+export class InvalidPlayerColorToken extends Error {
+  constructor (playerIdx, cause) {
+    super(`Invalid color token: there is no player at index ${playerIdx}. Make sure to use getColorToken() if you want the color of a specific player.`)
+    this.playerIdx = playerIdx
+    this.cause = cause
+    this.name = 'InvalidPlayerColorTokenError'
+  }
+}

engine/modules/entities/src/main/resources/view/entity-module/properties.js

@@ -1,13 +1,24 @@
 import { lerp, lerpColor, lerpAngle } from '../core/utils.js'
+import {ErrorLog} from '../core/ErrorLog.js'
+import {InvalidPlayerColorToken} from './errors/InvalidPlayerColorToken.js'
+
 
 const noLerp = (a, b, u) => u < 1 ? a : b
 const timeLerp = (a, b, u) => b < a ? b : lerp(a, b, u)
 
+
 const colorOpts = {
   type: Number,
   lerpMethod: lerpColor,
   convert (value, globalData) {
-    return value < 0 ? (globalData.players[-(value + 1)].color) : value
+    const playerIdx = -(value + 1)
+    
+    try {
+      return value < 0 ? (globalData.players[playerIdx].color) : value
+    } catch (error) {
+      ErrorLog.push(new InvalidPlayerColorToken(playerIdx))
+      return 0xffffff
+    }
   }
 }
 

playground/misc/misc-3-release-notes.md

@@ -2,6 +2,12 @@
 
 The CodinGame SDK is regularly updated and improved. This document lets you know what changed in the latest releases.
 
+## Next release
+
+### 🐞 Bug fix
+
+- `Invalid negative values for colours no longer crash the game`
+
 ## 3.4.8
 
 ### 🐞 Bug fix