Allow copying highlighted text and prevent editing when pressing ctrl+input key (#3431)

* Allow copying highlighted text

* Prevent editing when pressing ctrl+input key

* Add test

* Refactor conditions

* Revert changes

* Update test/copyPaste.test.tsx

Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>

* Move comments

* Check selection and add comment

* Refactor getSelection

* Allow ctrl+space

* Check control v inside isDefaultCellInput

* Refactor copying text

---------

Co-authored-by: Cheng <ycheng074@emea.comcast.com>
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Co-authored-by: Aman Mahajan <amahajan@stratag.com>

Author: 4 people

src/DataGrid.tsx

@@ -559,6 +559,8 @@ function DataGrid<R, SR, K extends Key>(
       const cKey = 67;
       const vKey = 86;
       if (keyCode === cKey) {
+        // copy highlighted text only
+        if (window.getSelection()?.isCollapsed === false) return;
         handleCopy();
         return;
       }

src/utils/keyboardUtils.ts

@@ -53,6 +53,8 @@ export function isCtrlKeyHeldDown(e: React.KeyboardEvent): boolean {
 }
 
 export function isDefaultCellInput(event: React.KeyboardEvent<HTMLDivElement>): boolean {
+  const vKey = 86;
+  if (isCtrlKeyHeldDown(event) && event.keyCode !== vKey) return false;
   return !nonInputKeys.has(event.key);
 }
 

test/copyPaste.test.tsx

@@ -200,3 +200,10 @@ test('should not allow paste on header or summary cells', async () => {
   expect(getSelectedCell()).toHaveTextContent('s1');
   expect(onPasteSpy).not.toHaveBeenCalled();
 });
+
+test('should not start editing when pressing ctrl+<input key>', async () => {
+  setup();
+  await userEvent.click(getCellsAtRowIndex(1)[0]);
+  await userEvent.keyboard('{Control>}b');
+  expect(getSelectedCell()).not.toHaveClass('rdg-editor-container');
+});