-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Hello there! Thank you very much for the package!
I wanted to point out two issues that might affect other users.
- Unnecessary conversion of sparse matrix to dense matrix, which explodes in memory for huge datasets. For me, with 100k peaks and 30k cells, it was impossible to run the method on personal machine. I have used the patched function of create.group.matrices without this line and it worked fine.
Line 116 in 34cb72d
| counts <- as.matrix(counts) |
- Problem with subsample group name parsing. If the group names do not have underscores, then all groups are just called "group" in the results.
Line 271 in 34cb72d
| het$state <- sub("-[^_]+$", "", het$state) |
I suggest using this line instead.
het$state <- sub("-\\d+$", "", het$state)
Thank you, and I hope it helps.
Best,
Anastasiya
Metadata
Metadata
Assignees
Labels
No labels