-
Notifications
You must be signed in to change notification settings - Fork 2
cx-32 add last login event feed #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,6 +98,12 @@ var ( | |
| field.WithDescription("Role name for the IAM role to assume when using the AWS connector"), | ||
| field.WithDefaultValue("OrganizationAccountAccessRole"), | ||
| ) | ||
| SyncSSOUserLastLogin = field.BoolField( | ||
| "sync-sso-user-last-login", | ||
| field.WithDisplayName("Sync SSO User Last Login"), | ||
| field.WithDescription("Enable fetching last login time for SSO users from CloudTrail (requires cloudtrail:LookupEvents permission)"), | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't we add a default value for this new config?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if i'm not wrong it takes false as default, but will make it explicit. |
||
| field.WithDefaultValue(false), | ||
| ) | ||
| ) | ||
|
|
||
| func ValidateExternalId(input string) error { | ||
|
|
@@ -146,6 +152,7 @@ var Config = field.NewConfiguration( | |
| UseAssumeField, | ||
| SyncSecrets, | ||
| IamAssumeRoleName, | ||
| SyncSSOUserLastLogin, | ||
| }, | ||
| field.WithConstraints( | ||
| field.FieldsDependentOn( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
aws-sdk-go-v2 v1.41.1 release notes github💡 Result:
github.com/aws/aws-sdk-go-v2v1.41.1 exists as a Git tag (v1.41.1) and is shown on pkg.go.dev as published Jan 9, 2026. [1]CHANGELOG.md(linked from the module page). [1]aws-sdk-go-v2is primarily date-based (e.g.,release-YYYY-MM-DD), not one GitHub Release per semver tag likev1.41.1. [2]Sources: [1] [2]
🌐 Web query:
google.golang.org/grpc v1.71.0 release notes minimum go version💡 Result:
google.golang.org/grpcv1.71.0 bumps the minimum supported Go version to Go 1.22.7 (listed under “Dependencies” in the v1.71.0 release notes). [1]🌐 Web query:
aws-sdk-go-v2 service cloudtrail v1.55.5 release notes💡 Result:
I couldn’t find any official AWS SDK for Go v2 release notes specifically for
github.com/aws/aws-sdk-go-v2/service/cloudtrailv1.55.5 (it doesn’t appear in the top-levelaws/aws-sdk-go-v2GitHub release notes). (github.com)What I can confirm from AWS’s published v2 release notes is that, on 2025-11-20, the CloudTrail service module was released/updated to
v1.55.0with the feature: “CloudTrail aggregated events to simplify monitoring of data events at scale.” (github.com)Also note:
v1.55.5does exist as a release number for the deprecated v1 SDK repo (aws/aws-sdk-go), but that’s a different SDK line thanaws-sdk-go-v2. (github.com)Citations:
🌐 Web query:
aws-sdk-go-v2 CHANGELOG.md v1.41 breaking changes💡 Result:
For the AWS SDK for Go v2, there are no breaking changes called out for “v1.41” in the repo’s published release notes—updates in that range are minor-version bumps (v1.x → v1.(x+1)), which are not where the project ships intentional breaking API changes under SemVer.
In the repo release notes where a module hits
v1.41.0(example:github.com/aws/aws-sdk-go-v2/service/sts: v1.41.0), the change is listed as a Feature addition (STSGetWebIdentityTokensupport), not a breaking change. [1]Source
service/sts: v1.41.0as a Feature, no breaking-change note) [1]🌐 Web query:
grpc-go v1.71.0 v1.70.0 breaking changes migration guide💡 Result:
grpc-go v1.70.0 → v1.71.0: breaking / migration notes
1) Custom balancers that record metrics
Breaking change:
balancer.BuildOptions.MetricsRecorderwas removed.Migration: get the recorder from the
balancer.ClientConninstead:opts.MetricsRecordercc.MetricsRecorder()(new method onbalancer.ClientConn) [1][2]2) Types implementing
balancer.ClientConn(usually in tests or intercepting/wrapping ClientConn)Breaking change: implementations must now embed/delegate another
balancer.ClientConnimplementation (to allow grpc-go to add methods without breaking you).Migration: change your wrapper/test double to embed the passed-in
balancer.ClientConnand forward calls, instead of implementing the interface “from scratch”. Also ensure the embedded delegate is never nil (or you may panic). [1][2][3]3)
balancer/endpointshardingconstructor signature changedBreaking change: constructor now takes the child balancer builder and an options struct.
Migration: update your call sites to pass
(childBuilder, esOpts)as required by the newNewBalancersignature. [1][4](Related) v1.70.0 behavior change you may hit while upgrading
If you have service configs with an invalid
retryPolicy, grpc-go now rejects them (potential breaking change if you previously relied on permissive parsing). Fix the service config to match the gRFC requirements. [5]Sources: [1] [2] [3] [4] [5]
🌐 Web query:
aws-sdk-go-v2 v1.40 v1.41 compatibility changes💡 Result:
What changed from
aws-sdk-go-v2v1.40.x → v1.41.x (compatibility-impacting)1) Default credential chain behavior change (v1.40.0)
v1.40.0added AWS Login credentials (credentials/logincreds) to the default credential chain. This is the main “compatibility” concern because it can change which credentials get picked up automatically (e.g., if your environment/shared config enables AWS Login, it may now be selected where it previously wasn’t). [1]2) No documented breaking API change for core module in v1.41.0 / v1.41.1
v1.41.0(Dec 8, 2025) andv1.41.1(Jan 9, 2026) exist as new core module versions, but AWS did not call out a core-module breaking change in the high-level release notes (they mostly list service-module updates). [2]Version timeline (core module)
github.com/aws/aws-sdk-go-v2v1.40.0 — Nov 19, 2025 [2]github.com/aws/aws-sdk-go-v2v1.41.0 — Dec 8, 2025 [2]github.com/aws/aws-sdk-go-v2v1.41.1 — Jan 9, 2026 [2]Sources:
[1] https://github.com/aws/aws-sdk-go-v2/releases (release “2025-11-19.2” highlights
github.com/aws/aws-sdk-go-v2: v1.40.0and the AWS Login creds addition)[2] https://pkg.go.dev/github.com/aws/aws-sdk-go-v2?tab=versions (version list + dates)
Verify gRPC minimum Go version requirement.
google.golang.org/grpcv1.71.0 requires Go 1.22.7 or later; confirm this aligns with the project's minimum supported Go version. While gRPC v1.71.0 includes breaking changes for custom balancer implementations, they do not affect typical SDK usage.aws-sdk-go-v2v1.41.1 has no documented breaking changes; note that v1.40.0 added AWS Login credentials to the default credential chain, which may alter credential resolution behavior.🤖 Prompt for AI Agents