Skip to content

Resource lookup service & protos for more details create account followups #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loganintech wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Resource lookup service & protos for more details create account followups #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
77618ef
Add protos for lookup service
loganintech Jan 27, 2025
2416636
The other work I need for the resource lookup service registration I …
loganintech Jan 27, 2025
4f72840
Implement the cliet parts of lookup resource
loganintech Jan 27, 2025
e902c68
Add a way to lookup resources via the command line
loganintech Jan 28, 2025
fe698e6
Actually define the lookup resource command, simplify some props
loganintech Jan 28, 2025
6136d9b
Some review suggestions
loganintech Jan 29, 2025
0ee5d8f
Missing E
loganintech Jan 29, 2025
7f21ce5
I think work
loganintech Jan 29, 2025
99fe222
Fix linter error.
ggreer Feb 12, 2025
f4dea99
Rename resource lookup to account creation status. Use createaccountr…
ggreer Feb 12, 2025
0151582
Fix proto lint errors.
ggreer Feb 12, 2025
a2f6c78
Fix linter error caused by new version of golangci-lint
ggreer Feb 12, 2025
d04dee8
Don't break backwards compatibility in protos. This is repetitive but…
ggreer Feb 12, 2025
41a3fcf
Clean up account creation status API.
ggreer Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions internal/connector/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ type connectorClient struct {
connectorV2.GrantManagerServiceClient
connectorV2.ResourceManagerServiceClient
connectorV2.AccountManagerServiceClient
connectorV2.AccountCreationStatusServiceClient
connectorV2.CredentialManagerServiceClient
connectorV2.EventServiceClient
connectorV2.TicketsServiceClient
Expand All @@ -53,13 +54,14 @@ var ErrConnectorNotImplemented = errors.New("client does not implement connector
type wrapper struct {
mtx sync.RWMutex

server types.ConnectorServer
client types.ConnectorClient
serverStdin io.WriteCloser
conn *grpc.ClientConn
provisioningEnabled bool
ticketingEnabled bool
fullSyncDisabled bool
server types.ConnectorServer
client types.ConnectorClient
serverStdin io.WriteCloser
conn *grpc.ClientConn
provisioningEnabled bool
ticketingEnabled bool
fullSyncDisabled bool
getAccountCreationStatusEnabled bool

rateLimiter ratelimitV1.RateLimiterServiceServer
rlCfg *ratelimitV1.RateLimiterConfig
Expand Down Expand Up @@ -98,6 +100,13 @@ func WithProvisioningEnabled() Option {
}
}

func WithAccountCreationStatusEnabled() Option {
return func(ctx context.Context, w *wrapper) error {
w.getAccountCreationStatusEnabled = true
return nil
}
}

func WithFullSyncDisabled() Option {
return func(ctx context.Context, w *wrapper) error {
w.fullSyncDisabled = true
Expand Down Expand Up @@ -178,6 +187,10 @@ func (cw *wrapper) Run(ctx context.Context, serverCfg *connectorwrapperV1.Server
connectorV2.RegisterTicketsServiceServer(server, noop)
}

if cw.getAccountCreationStatusEnabled {
connectorV2.RegisterResourceManagerServiceServer(server, cw.server)
}

if cw.provisioningEnabled {
connectorV2.RegisterGrantManagerServiceServer(server, cw.server)
connectorV2.RegisterResourceManagerServiceServer(server, cw.server)
Expand Down
3 changes: 2 additions & 1 deletion internal/connector/noop_provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ package connector
import (
"context"

v2 "github.com/conductorone/baton-sdk/pb/c1/connector/v2"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"

v2 "github.com/conductorone/baton-sdk/pb/c1/connector/v2"
)

type noopProvisioner struct{}
Expand Down
Loading
Loading