Skip to content

Log Errors from Targeted Sync, but don't stop the whole sync #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mj-palanker wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Log Errors from Targeted Sync, but don't stop the whole sync #474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89f8bd9
swallow errors from targeted sync
mj-palanker Sep 12, 2025
b5e54c9
better
mj-palanker Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/sync/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,11 @@
s.state.FinishAction(ctx)
continue
}
if codes.Code(status.Code(err)) == codes.NotFound && s.syncType == connectorstore.SyncTypePartial {

Check failure on line 495 in pkg/sync/syncer.go

View workflow job for this annotation

GitHub Actions / go-lint 

unnecessary conversion (unconvert)
l.Warn("sync targeted resource not found, continuing to sync other resources", zap.Any("stateAction", stateAction), zap.Error(err))
s.state.FinishAction(ctx)
continue
}
Copy link

@cursor cursor bot Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unreachable Error Handling in Sync Logic

The new if block for codes.NotFound errors in partial syncs is unreachable. The preceding isWarning(ctx, err) check already handles NotFound errors and continues, preventing this specific logic from executing. The codes.Code(status.Code(err)) conversion is also redundant.

Fix in Cursor Fix in Web

if !retryer.ShouldWaitAndRetry(ctx, err) {
return err
}
Expand Down
Loading