Ensure network check doesn't fail on importing fcntl on Windows (DataDog#8459)

* Ensure network check doesn't fail on importing fcntl on Windows

* test

* Add network to windows ci

* Remove extra blank line

* Update test-all-checks

* Fix display name

* Update network/datadog_checks/network/network.py

Co-authored-by: Paul <paul.coignet@datadoghq.com>

Co-authored-by: Paul Coignet <paul.coignet@datadoghq.com>

Author: Slavek Kabrda

.azure-pipelines/changes.yml

@@ -27,7 +27,7 @@ jobs:
 - template: './templates/test-single-windows.yml'
   parameters:
     job_name: Changed
-    check: '--changed datadog_checks_base datadog_checks_dev active_directory aspdotnet azure_iot_edge disk dns_check dotnetclr exchange_server iis pdh_check sqlserver tcp_check win32_event_log windows_service wmi_check'
+    check: '--changed datadog_checks_base datadog_checks_dev active_directory aspdotnet azure_iot_edge disk dns_check dotnetclr exchange_server iis network pdh_check sqlserver tcp_check win32_event_log windows_service wmi_check'
     display: Windows
     pip_cache_config:
       key: 'pip | $(Agent.OS) | datadog_checks_base/datadog_checks/base/data/agent_requirements.in'

.azure-pipelines/templates/test-all-checks.yml

@@ -291,8 +291,11 @@ jobs:
       displayName: Nagios
       os: linux
     - checkName: network
-      displayName: Network
+      displayName: Network (Linux)
       os: linux
+    - checkName: network
+      displayName: Network (Windows)
+      os: windows
     - checkName: nfsstat
       displayName: NFSstat
       os: linux

network/datadog_checks/network/network.py

@@ -8,7 +8,6 @@
 
 import array
 import distutils.spawn
-import fcntl
 import os
 import re
 import socket
@@ -28,6 +27,11 @@
 except ImportError:
     from datadog_checks.base.stubs import datadog_agent
 
+try:
+    import fcntl
+except ImportError:
+    fcntl = None
+
 if PY3:
     long = int
 
@@ -87,6 +91,8 @@ def check(self, instance):
         self._collect_rate_metrics = instance.get('collect_rate_metrics', True)
         self._collect_count_metrics = instance.get('collect_count_metrics', False)
         self._collect_ena_metrics = instance.get('collect_aws_ena_metrics', False)
+        if fcntl is None and self._collect_ena_metrics:
+            raise ConfigurationError("fcntl not importable, collect_aws_ena_metrics should be disabled")
 
         # This decides whether we should split or combine connection states,
         # along with a few other things

network/tests/test_network.py

@@ -386,6 +386,7 @@ def send_ethtool_ioctl_mock(iface, sckt, data):
     raise ValueError("Couldn't match any iface/data combination in the test data")
 
 
+@pytest.mark.skipif(platform.system() == 'Windows', reason="Only runs on Unix systems")
 @mock.patch('datadog_checks.network.network.Network._send_ethtool_ioctl')
 def test_collect_ena(send_ethtool_ioctl, check):
     send_ethtool_ioctl.side_effect = send_ethtool_ioctl_mock
@@ -398,6 +399,7 @@ def test_collect_ena(send_ethtool_ioctl, check):
     }
 
 
+@pytest.mark.skipif(platform.system() == 'Windows', reason="Only runs on Unix systems")
 @mock.patch('datadog_checks.network.network.Network._send_ethtool_ioctl')
 def test_submit_ena(send_ethtool_ioctl, check, aggregator):
     send_ethtool_ioctl.side_effect = send_ethtool_ioctl_mock
@@ -418,12 +420,14 @@ def test_submit_ena(send_ethtool_ioctl, check, aggregator):
         aggregator.assert_metric(m, count=1, value=0, tags=['device:eth0'])
 
 
+@pytest.mark.skipif(platform.system() == 'Windows', reason="Only runs on Unix systems")
 @mock.patch('datadog_checks.network.network.Network._send_ethtool_ioctl')
 def test_collect_ena_values_not_present(send_ethtool_ioctl, check):
     send_ethtool_ioctl.side_effect = send_ethtool_ioctl_mock
     assert check._collect_ena('enp0s3') == {}
 
 
+@pytest.mark.skipif(platform.system() == 'Windows', reason="Only runs on Unix systems")
 @mock.patch('fcntl.ioctl')
 def test_collect_ena_unsupported_on_iface(ioctl_mock, check, caplog):
     caplog.set_level(logging.DEBUG)