Skip to content

Commit 798787d

Browse files
committed
🔧 refactor: replace all instances of Dict with dict for better readability and consistency
🐛 fix(test_convex_multi_thread.py): correct typo in function name from 'process_convex_depoly' to 'process_convex_deploy' for better code clarity
1 parent bd27920 commit 798787d

File tree

4 files changed

+12
-15
lines changed

4 files changed

+12
-15
lines changed

convex_api/api.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from typing import TYPE_CHECKING
99

1010
if TYPE_CHECKING:
11-
from typing import Any, Dict
11+
from typing import Any
1212

1313
import logging
1414
import re
@@ -644,9 +644,9 @@ def _post(
644644
url: str,
645645
data: CreateAccountRequest | FaucetRequest | QueryRequest | PrepareTransactionRequest | SubmitTransactionRequest,
646646
sequence_retry_count: int = 20
647-
) -> Dict[str, Any] | None:
647+
) -> dict[str, Any] | None:
648648
max_sleep_time_seconds = 1
649-
result: Dict[str, Any] | None = None
649+
result: dict[str, Any] | None = None
650650
while sequence_retry_count >= 0:
651651
response = requests.post(url, data=data.model_dump_json())
652652
if response.status_code == 200:

convex_api/tool/command/argparse_typing.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
)
55
from typing import (
66
Any,
7-
Dict,
87
Protocol
98
)
109

@@ -16,7 +15,7 @@
1615

1716
class SubParsersAction(Protocol):
1817
@property
19-
def choices(self) -> Dict[str, ArgumentParser]:
18+
def choices(self) -> dict[str, ArgumentParser]:
2019
...
2120

2221
def add_parser(self, name: str, **kwargs: Any) -> ArgumentParser:

convex_api/tool/output.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,12 @@
55
66
"""
77
import json
8-
from typing import Dict
98

109

1110
class Output:
1211
def __init__(self):
1312
self._line_list: list[str] = []
14-
self._values: Dict[str, str | int] = {}
13+
self._values: dict[str, str | int] = {}
1514
self._error_list: list[str] = []
1615

1716
def add_error(self, line: str):
@@ -20,14 +19,14 @@ def add_error(self, line: str):
2019
def add_line(self, line: str):
2120
self._line_list.append(line)
2221

23-
def add_line_values(self, values: Dict[str, str | int]):
22+
def add_line_values(self, values: dict[str, str | int]):
2423
for name, value in values.items():
2524
self.add_line(f'{name}: {value}')
2625

2726
def set_value(self, key: str, value: str | int):
2827
self._values[key] = value
2928

30-
def set_values(self, values: Dict[str, str | int]):
29+
def set_values(self, values: dict[str, str | int]):
3130
for name, value in values.items():
3231
self.set_value(name, value)
3332

tests/intergration/test_convex_multi_thread.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
)
1111
from typing import (
1212
Any,
13-
Dict
1413
)
1514

1615
import pytest # type: ignore # noqa: F401
@@ -43,7 +42,7 @@ def test_convex_api_multi_thread_send(convex_url: str, test_account: Account):
4342
process_count = 4
4443
convex = API(convex_url)
4544
convex.topup_account(test_account)
46-
process_items: Dict[int, Dict[str, Any]] = {}
45+
process_items: dict[int, dict[str, Any]] = {}
4746
for index in range(process_count):
4847
result_value = Value('i', 0)
4948
proc = Process(target=process_on_convex, args=(convex, test_account, result_value))
@@ -69,7 +68,7 @@ def process_convex_account_creation(convex: API, result_value: Any):
6968
def test_convex_api_multi_thread_account_creation(convex_url: str):
7069
process_count = 20
7170
convex = API(convex_url)
72-
process_items: Dict[int, Dict[str, Any]] = {}
71+
process_items: dict[int, dict[str, Any]] = {}
7372
for index in range(process_count):
7473
result_value = Value('i', 0)
7574
proc = Process(target=process_convex_account_creation, args=(convex, result_value))
@@ -84,7 +83,7 @@ def test_convex_api_multi_thread_account_creation(convex_url: str):
8483
assert process_item['result_value'].value == 1
8584

8685

87-
def process_convex_depoly(convex: API, result_value: Any):
86+
def process_convex_deploy(convex: API, result_value: Any):
8887
deploy_storage = """
8988
(def storage-example
9089
(deploy
@@ -133,10 +132,10 @@ def test_convex_api_multi_thread_deploy(convex_url: str):
133132
key_pair = KeyPair()
134133
account = convex.create_account(key_pair)
135134
convex.request_funds(TEST_FUNDING_AMOUNT, account)
136-
process_items: Dict[int, Dict[str, Any]] = {}
135+
process_items: dict[int, dict[str, Any]] = {}
137136
for index in range(process_count):
138137
result_value = Value('i', 0)
139-
proc = Process(target=process_convex_depoly, args=(convex, result_value))
138+
proc = Process(target=process_convex_deploy, args=(convex, result_value))
140139
process_items[index] = {
141140
'process': proc,
142141
'result_value': result_value

0 commit comments

Comments
 (0)