Merge branch 'develop-remove-deprecatedType'. Close #500.

**Description**

The functions `Copilot.Core.Type.typename`,
`Copilot.Core.Type.tylength`, `Copilot.Core.Type.tysize`,
`Copilot.Core.Type.fieldname`, `Copilot.Core.Type.accessorname` and
`Copilot.Core.Type.Array.arrayelems` are not being used by any other
part of Copilot.

They were replaced by functions with similar names in lowerCamelCase
format. The original functions were deprecated in Copilot 3.17 and no
messages have been received requesting that they be kept in this
library.

As per our internal policy of waiting 3 versions from deprecation until
a public interface declaration can be removed, these functions can now
be removed.

**Type**

- Bug: unused code included in the implementation.

**Additional context**

- Issue #457, addressed in Copilot 3.17, deprecated the functions.

**Requester**

- Ivan Perez

**Method to check presence of bug**

There is no easy, forward-compatible, automated way of detecting that
the functions are present and also deprecated. Manual inspection is
recommended. At present, they are the only deprecated functions in
`copilot-core`, so their presence can be found with:

```sh
$ grep -nHre 'DEPRECATED' src/
src/Copilot/Core/Type.hs:58:-- {-# DEPRECATED typename "Use typeName instead." #-}
src/Copilot/Core/Type.hs:85:-- {-# DEPRECATED fieldname "Use fieldName instead." #-}
src/Copilot/Core/Type.hs:96:-- {-# DEPRECATED accessorname "Use accessorName instead." #-}
src/Copilot/Core/Type.hs:139:-- {-# DEPRECATED tylength "Use typeLength instead." #-}
src/Copilot/Core/Type.hs:149:-- {-# DEPRECATED tysize "Use typeSize instead." #-}
src/Copilot/Core/Type/Array.hs:47:{-# DEPRECATED arrayelems "Use ArrayElems instead." #-}
```

**Expected result**

The strings returned by the command above should be empty (nothing is
deprecated).

**Solution implemented**

Remove the deprecated functions from `Copilot.Core.Type` and
`Copilot.Core.Type.Array`.

**Further notes**

None.

Author: ivanperez-keera

copilot-core/CHANGELOG

@@ -1,3 +1,7 @@
+2024-03-07
+        * Remove deprecated functions in Copilot.Core.Type and
+          Copilot.Core.Type.Array. (#500)
+
 2024-01-07
         * Version bump (3.18.1). (#493)
 

copilot-core/src/Copilot/Core/Type.hs

@@ -24,21 +24,16 @@ module Copilot.Core.Type
     , SimpleType (..)
 
     , typeSize
-    , tysize
     , typeLength
-    , tylength
 
     , Value (..)
     , toValues
     , Field (..)
     , typeName
-    , typename
 
     , Struct
     , fieldName
-    , fieldname
     , accessorName
-    , accessorname
     )
   where
 
@@ -55,18 +50,11 @@ import GHC.TypeLits       (KnownNat, KnownSymbol, Symbol, natVal, sameNat,
 -- Internal imports
 import Copilot.Core.Type.Array (Array)
 
-{-# DEPRECATED typename "Use typeName instead." #-}
-
 -- | The value of that is a product or struct, defined as a constructor with
 -- several fields.
 class Struct a where
   -- | Returns the name of struct in the target language.
   typeName :: a -> String
-  typeName = typename
-
-  -- | Returns the name of struct in the target language.
-  typename :: a -> String
-  typename = typeName
 
   -- | Transforms all the struct's fields into a list of values.
   toValues :: a -> [Value a]
@@ -83,24 +71,12 @@ data Field (s :: Symbol) t = Field t
 fieldName :: forall s t . KnownSymbol s => Field s t -> String
 fieldName _ = symbolVal (Proxy :: Proxy s)
 
-{-# DEPRECATED fieldname "Use fieldName instead." #-}
--- | Extract the name of a field.
-fieldname :: forall s t . KnownSymbol s => Field s t -> String
-fieldname = fieldName
-
 -- | Extract the name of an accessor (a function that returns a field of a
 -- struct).
 accessorName :: forall a s t . (Struct a, KnownSymbol s)
              => (a -> Field s t) -> String
 accessorName _ = symbolVal (Proxy :: Proxy s)
 
-{-# DEPRECATED accessorname "Use accessorName instead." #-}
--- | Extract the name of an accessor (a function that returns a field of a
--- struct).
-accessorname :: forall a s t . (Struct a, KnownSymbol s)
-             => (a -> Field s t) -> String
-accessorname = accessorName
-
 instance (KnownSymbol s, Show t) => Show (Field s t) where
   show f@(Field v) = fieldName f ++ ":" ++ show v
 
@@ -137,21 +113,11 @@ data Type :: * -> * where
 typeLength :: forall n t . KnownNat n => Type (Array n t) -> Int
 typeLength _ = fromIntegral $ natVal (Proxy :: Proxy n)
 
-{-# DEPRECATED tylength "Use typeLength instead." #-}
--- | Return the length of an array from its type
-tylength :: forall n t . KnownNat n => Type (Array n t) -> Int
-tylength = typeLength
-
 -- | Return the total (nested) size of an array from its type
 typeSize :: forall n t . KnownNat n => Type (Array n t) -> Int
 typeSize ty@(Array ty'@(Array _)) = typeLength ty * typeSize ty'
 typeSize ty@(Array _            ) = typeLength ty
 
-{-# DEPRECATED tysize "Use typeSize instead." #-}
--- | Return the total (nested) size of an array from its type
-tysize :: forall n t . KnownNat n => Type (Array n t) -> Int
-tysize = typeSize
-
 instance TestEquality Type where
   testEquality Bool   Bool   = Just DE.Refl
   testEquality Int8   Int8   = Just DE.Refl

copilot-core/src/Copilot/Core/Type/Array.hs

@@ -14,7 +14,6 @@ module Copilot.Core.Type.Array
     ( Array
     , array
     , arrayElems
-    , arrayelems
     )
   where
 
@@ -43,8 +42,3 @@ array xs | datalen == typelen = Array xs
 -- | Return the elements of an array.
 arrayElems :: Array n a -> [a]
 arrayElems (Array xs) = xs
-
-{-# DEPRECATED arrayelems "Use ArrayElems instead." #-}
--- | Return the elemts of an array.
-arrayelems :: Array n a -> [a]
-arrayelems = arrayElems