refactor(NameDescriptionForm): remove react-emitter-factory

Author: purfectliterature

client/app/bundles/course/group/forms/NameDescriptionForm.jsx

@@ -1,4 +1,4 @@
-import useEmitterFactory from 'react-emitter-factory';
+import { useEffect } from 'react';
 import { Controller, useForm } from 'react-hook-form';
 import { defineMessages, FormattedMessage } from 'react-intl';
 import { yupResolver } from '@hookform/resolvers/yup';
@@ -44,7 +44,7 @@ const validationSchema = yup.object({
 });
 
 const NameDescriptionForm = (props) => {
-  const { initialValues, onSubmit } = props;
+  const { initialValues, onSubmit, onDirtyChange } = props;
   const {
     control,
     handleSubmit,
@@ -55,13 +55,9 @@ const NameDescriptionForm = (props) => {
     resolver: yupResolver(validationSchema),
   });
 
-  useEmitterFactory(
-    props,
-    {
-      isDirty,
-    },
-    [isDirty],
-  );
+  useEffect(() => {
+    onDirtyChange?.(isDirty);
+  }, [isDirty]);
 
   return (
     <form
@@ -119,6 +115,7 @@ const NameDescriptionForm = (props) => {
 NameDescriptionForm.propTypes = {
   initialValues: PropTypes.object,
   onSubmit: PropTypes.func.isRequired,
+  onDirtyChange: PropTypes.func,
 };
 
 export default NameDescriptionForm;

client/app/bundles/course/group/pages/GroupNew/index.jsx

@@ -56,13 +56,11 @@ const PopupDialog = ({ dispatch, intl, isManagingGroups }) => {
         skipConfirmation={!isDirty}
       >
         <NameDescriptionForm
-          emitsVia={(nameDescriptionForm) =>
-            setIsDirty(nameDescriptionForm.isDirty)
-          }
           initialValues={{
             name: '',
             description: '',
           }}
+          onDirtyChange={setIsDirty}
           onSubmit={onFormSubmit}
         />
       </GroupFormDialog>

client/app/bundles/course/group/pages/GroupShow/CategoryCard.jsx

@@ -172,13 +172,11 @@ const CategoryCard = ({
             skipConfirmation={!isDirty}
           >
             <NameDescriptionForm
-              emitsVia={(nameDescriptionForm) =>
-                setIsDirty(nameDescriptionForm.isDirty)
-              }
               initialValues={{
                 name: category.name,
                 description: category.description,
               }}
+              onDirtyChange={setIsDirty}
               onSubmit={onFormSubmit}
             />
           </GroupFormDialog>

client/app/bundles/course/group/pages/GroupShow/GroupManager/GroupUserManager.jsx

@@ -496,13 +496,11 @@ const GroupUserManager = ({
         skipConfirmation={!isDirty}
       >
         <NameDescriptionForm
-          emitsVia={(nameDescriptionForm) =>
-            setIsDirty(nameDescriptionForm.isDirty)
-          }
           initialValues={{
             name: group.name,
             description: group.description,
           }}
+          onDirtyChange={setIsDirty}
           onSubmit={onFormSubmit}
         />
       </GroupFormDialog>