MTL-1497 add shellcheck #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsalmela
force-pushed
the
add-shellcheck
branch
from
98b2f80 to
dd727fb
Compare
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
jacobsalmela
force-pushed
the
add-shellcheck
branch
from
5b22655 to
7382d8f
Compare
|
Why the MIT License updates (which seem unrelated). Does shellcheck require such? |
Author
|
The HPE license checker fails if a file does not have it |
rustydb
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacob Salmela jacob.salmela@hpe.com
Summary and Scope
This adds a shellcheck Action. It's set to fail on warnings or errors. As a starting point, I disabled the existing warnings and any future scripts will need to pass this gate.
Issue Type
Adds shellcheck workflow to this repo.
Prerequisites
Idempotency
N/A
Risks and Mitigations
Low
Pull Request Checklist