accurate culling

# Conflicts:
#	src/main/java/com/simibubi/create/content/kinetics/chainConveyor/ChainConveyorBlockEntity.java
#	src/main/java/com/simibubi/create/content/kinetics/chainConveyor/ChainConveyorRenderer.java
#	src/main/resources/create.mixins.json

Author: MoePus

src/main/java/com/simibubi/create/content/kinetics/chainConveyor/ChainConveyorBlockEntity.java

@@ -88,7 +88,7 @@ public ChainConveyorBlockEntity(BlockEntityType<?> typeIn, BlockPos pos, BlockSt
 
 	@Override
 	protected AABB createRenderBoundingBox() {
-		return new AABB(worldPosition).inflate(connections.isEmpty() ? 3 : 64);
+		return AABB.INFINITE;
 	}
 
 	@Override

src/main/java/com/simibubi/create/content/kinetics/chainConveyor/ChainConveyorRenderer.java

@@ -3,6 +3,7 @@
 import java.util.List;
 import java.util.Map.Entry;
 
+import org.joml.FrustumIntersection;
 import org.joml.Matrix4f;
 
 import com.mojang.blaze3d.vertex.PoseStack;
@@ -52,25 +53,33 @@ protected void renderSafe(ChainConveyorBlockEntity be, float partialTicks, PoseS
 		super.renderSafe(be, partialTicks, ms, buffer, light, overlay);
 		BlockPos pos = be.getBlockPos();
 
-		renderChains(be, ms, buffer, light, overlay);
+		FrustumIntersection frustum = null;
+		Vec3 camPos = null;
+		if(Minecraft.getInstance().level == be.getLevel())
+		{
+			frustum = getFrustumIntersection();
+			camPos = Minecraft.getInstance().gameRenderer.getMainCamera().getPosition();
+		}
+		renderChains(be, ms, buffer, light, overlay, frustum, camPos);
 
 		if (VisualizationManager.supportsVisualization(be.getLevel()))
 			return;
 
-		CachedBuffers.partial(AllPartialModels.CHAIN_CONVEYOR_WHEEL, be.getBlockState())
-			.light(light)
-			.overlay(overlay)
-			.renderInto(ms, buffer.getBuffer(RenderType.cutoutMipped()));
+		if (frustum != null && frustum.testAab(pos.getX() - 2 - (float) camPos.x, pos.getY() - (float) camPos.y, pos.getZ() - 2 - (float) camPos.z, pos.getX() + 2 - (float) camPos.x, pos.getY() + 1 - (float) camPos.y, pos.getZ() + 2 - (float) camPos.z))
+			CachedBuffers.partial(AllPartialModels.CHAIN_CONVEYOR_WHEEL, be.getBlockState())
+				.light(light)
+				.overlay(overlay)
+				.renderInto(ms, buffer.getBuffer(RenderType.cutoutMipped()));
 
 		for (ChainConveyorPackage box : be.loopingPackages)
-			renderBox(be, ms, buffer, overlay, pos, box, partialTicks);
+			renderBox(be, ms, buffer, overlay, pos, box, partialTicks, frustum, camPos);
 		for (Entry<BlockPos, List<ChainConveyorPackage>> entry : be.travellingPackages.entrySet())
 			for (ChainConveyorPackage box : entry.getValue())
-				renderBox(be, ms, buffer, overlay, pos, box, partialTicks);
+				renderBox(be, ms, buffer, overlay, pos, box, partialTicks, frustum, camPos);
 	}
 
 	private void renderBox(ChainConveyorBlockEntity be, PoseStack ms, MultiBufferSource buffer, int overlay,
-		BlockPos pos, ChainConveyorPackage box, float partialTicks) {
+		BlockPos pos, ChainConveyorPackage box, float partialTicks, FrustumIntersection frustum, Vec3 camPos) {
 		if (box.worldPosition == null)
 			return;
 		if (box.item == null || box.item.isEmpty())
@@ -82,6 +91,9 @@ private void renderBox(ChainConveyorBlockEntity be, PoseStack ms, MultiBufferSou
 
 		Vec3 position = physicsData.prevPos.lerp(physicsData.pos, partialTicks);
 		Vec3 targetPosition = physicsData.prevTargetPos.lerp(physicsData.targetPos, partialTicks);
+		if (frustum != null && !frustum.testSphere((float) (targetPosition.x - camPos.x), (float) (targetPosition.y - camPos.y), (float) (targetPosition.z - camPos.z), 1))
+			return;
+
 		float yaw = AngleHelper.angleLerp(partialTicks, physicsData.prevYaw, physicsData.yaw);
 		Vec3 offset =
 			new Vec3(targetPosition.x - pos.getX(), targetPosition.y - pos.getY(), targetPosition.z - pos.getZ());
@@ -141,7 +153,7 @@ private static Vec3 getClosestPointOnChain(Vec3 cam, Vec3 start, Vec3 end) {
 	}
 
 	private void renderChains(ChainConveyorBlockEntity be, PoseStack ms, MultiBufferSource buffer, int light,
-		int overlay) {
+		int overlay, FrustumIntersection frustum, Vec3 camPos) {
 		float time = AnimationTickHolder.getRenderTime(be.getLevel()) / (360f / Math.abs(be.getSpeed()));
 		time %= 1;
 		if (time < 0)
@@ -154,6 +166,10 @@ private void renderChains(ChainConveyorBlockEntity be, PoseStack ms, MultiBuffer
 			if (stats == null)
 				continue;
 
+			if (frustum != null && !frustum.testLineSegment((float) (stats.start().x - camPos.x), (float) (stats.start().y - camPos.y), (float) (stats.start().z - camPos.z),
+				(float) (stats.end().x - camPos.x), (float) (stats.end().y - camPos.y), (float) (stats.end().z - camPos.z))) {
+				continue;
+			}
 			Vec3 diff = stats.end()
 				.subtract(stats.start());
 			double yaw = (float) Mth.RAD_TO_DEG * Mth.atan2(diff.x, diff.z);
@@ -193,9 +209,7 @@ private void renderChains(ChainConveyorBlockEntity be, PoseStack ms, MultiBuffer
 				level.getBrightness(LightLayer.SKY, tilePos.offset(blockPos)));
 
 			boolean far = false;
-			if (Minecraft.getInstance().level == be.getLevel()) {
-				Vec3 camPos = Minecraft.getInstance()
-					.getBlockEntityRenderDispatcher().camera.getPosition();
+			if (frustum != null) {
 				Vec3 closest = getClosestPointOnChain(camPos, stats.start(), stats.end());
 				if (closest.distanceToSqr(camPos) > MIP_DISTANCE_SQR)
 					far = true;

src/main/java/com/simibubi/create/foundation/blockEntity/renderer/SafeBlockEntityRenderer.java

@@ -6,6 +6,7 @@
 import com.simibubi.create.foundation.blockEntity.CachedRenderBBBlockEntity;
 import com.simibubi.create.foundation.mixin.accessor.LevelRendererAccessor;
 
+import com.simibubi.create.foundation.mixin.accessor.FrustumAccessor;
 import com.simibubi.create.foundation.mixin.accessor.LevelRendererAccessor;
 
 import net.createmod.ponder.api.level.PonderLevel;
@@ -19,6 +20,8 @@
 import net.minecraft.world.phys.AABB;
 import net.minecraft.world.phys.Vec3;
 
+import org.joml.FrustumIntersection;
+
 public abstract class SafeBlockEntityRenderer<T extends BlockEntity> implements BlockEntityRenderer<T> {
 	@Override
 	public final void render(T be, float partialTicks, PoseStack ms, MultiBufferSource bufferSource, int light,
@@ -36,14 +39,20 @@ public boolean isInvalid(T be) {
 			.getBlock() == Blocks.AIR;
 	}
 
+	public Frustum getFrustum() {
+		LevelRendererAccessor accessor = (LevelRendererAccessor) Minecraft.getInstance().levelRenderer;
+		return accessor.create$getCapturedFrustum() != null ? accessor.create$getCapturedFrustum() : accessor.create$getCullingFrustum();
+	}
+
+	public FrustumIntersection getFrustumIntersection() {
+		return ((FrustumAccessor) getFrustum()).create$getFrustumIntersection();
+	}
+
 	public boolean shouldCullItem(Vec3 itemPos, Level level) {
 		if (level instanceof PonderLevel)
 			return false;
 
-		LevelRendererAccessor accessor = (LevelRendererAccessor) Minecraft.getInstance().levelRenderer;
-		Frustum frustum = accessor.create$getCapturedFrustum() != null ?
-			accessor.create$getCapturedFrustum() :
-			accessor.create$getCullingFrustum();
+		Frustum frustum = getFrustum();
 
 		AABB itemBB = new AABB(
 				itemPos.x - 0.25,

src/main/java/com/simibubi/create/foundation/mixin/accessor/FrustumAccessor.java

@@ -0,0 +1,13 @@
+package com.simibubi.create.foundation.mixin.accessor;
+
+import net.minecraft.client.renderer.culling.Frustum;
+
+import org.joml.FrustumIntersection;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.gen.Accessor;
+
+@Mixin(Frustum.class)
+public interface FrustumAccessor {
+	@Accessor("intersection")
+	FrustumIntersection create$getFrustumIntersection();
+}

src/main/resources/create.mixins.json

@@ -53,6 +53,7 @@
     "accessor.AgeableListModelAccessor",
     "accessor.EntityRenderDispatcherAccessor",
     "accessor.FontAccessor",
+    "accessor.FrustumAccessor",
     "accessor.GuiAccessor",
     "accessor.HumanoidArmorLayerAccessor",
     "accessor.LevelRendererAccessor",