From 1f99542cea0fb3912210d9559da210fdcc3a45ae Mon Sep 17 00:00:00 2001 From: Jez Barnsley Date: Tue, 18 Nov 2025 09:07:29 +0000 Subject: [PATCH] Gives correct JSON values in email --- src/server/forms/register-as-a-unicorn-breeder.yaml | 3 ++- src/server/plugins/engine/components/DeclarationField.test.ts | 4 ++-- src/server/plugins/engine/components/DeclarationField.ts | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/server/forms/register-as-a-unicorn-breeder.yaml b/src/server/forms/register-as-a-unicorn-breeder.yaml index ff8408dde..a92b727ab 100644 --- a/src/server/forms/register-as-a-unicorn-breeder.yaml +++ b/src/server/forms/register-as-a-unicorn-breeder.yaml @@ -240,7 +240,8 @@ pages: title: Declaration type: DeclarationField content: 'Fill in this field' - options: {} + options: + required: false next: - path: '/summary' conditions: diff --git a/src/server/plugins/engine/components/DeclarationField.test.ts b/src/server/plugins/engine/components/DeclarationField.test.ts index 461556a1a..ffa163cb8 100644 --- a/src/server/plugins/engine/components/DeclarationField.test.ts +++ b/src/server/plugins/engine/components/DeclarationField.test.ts @@ -197,7 +197,7 @@ describe('DeclarationField', () => { const payload2 = field.getFormDataFromState(state2) expect(payload1).toEqual(getFormData('true')) - expect(payload2).toEqual(getFormData('unchecked')) + expect(payload2).toEqual(getFormData('false')) }) it('returns value from state', () => { @@ -208,7 +208,7 @@ describe('DeclarationField', () => { const value2 = field.getFormValueFromState(state2) expect(value1).toBe('true') - expect(value2).toBe('unchecked') + expect(value2).toBe('false') }) it('returns context for conditions and form submission', () => { diff --git a/src/server/plugins/engine/components/DeclarationField.ts b/src/server/plugins/engine/components/DeclarationField.ts index c0b07c8f0..e2930155e 100644 --- a/src/server/plugins/engine/components/DeclarationField.ts +++ b/src/server/plugins/engine/components/DeclarationField.ts @@ -68,12 +68,12 @@ export class DeclarationField extends FormComponent { getFormValueFromState(state: FormSubmissionState) { const { name } = this - return state[name] === true ? 'true' : 'unchecked' + return state[name] === true ? 'true' : 'false' } getFormDataFromState(state: FormSubmissionState): FormPayload { const { name } = this - return { [name]: state[name] === true ? 'true' : 'unchecked' } + return { [name]: state[name] === true ? 'true' : 'false' } } getStateFromValidForm(payload: FormPayload): FormState {