From 8beb8651530168780269a1c04e204d2e56b1d0d6 Mon Sep 17 00:00:00 2001 From: Jez Barnsley Date: Tue, 28 Apr 2026 15:13:42 +0100 Subject: [PATCH 1/2] Ignore live preview submissions --- src/services/report.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/services/report.js b/src/services/report.js index 9c0d667..9a86998 100644 --- a/src/services/report.js +++ b/src/services/report.js @@ -51,10 +51,13 @@ export async function generateReportTimeline(date) { for await (const submission of submissionsCursor) { const status = submission.meta.status + const isPreview = submission.meta.isPreview if (status === FormStatus.Draft) { incrementFormCount(timelineMapDraft, submission.meta.formId) } else { - incrementFormCount(timelineMapLive, submission.meta.formId) + if (!isPreview) { + incrementFormCount(timelineMapLive, submission.meta.formId) + } } } From 49c839951de14a55c4235fa8d5ae86c51fb61bc8 Mon Sep 17 00:00:00 2001 From: Jez Barnsley Date: Wed, 29 Apr 2026 08:50:46 +0100 Subject: [PATCH 2/2] Sonar fix --- src/services/report.js | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/services/report.js b/src/services/report.js index 9a86998..6f6db90 100644 --- a/src/services/report.js +++ b/src/services/report.js @@ -8,8 +8,12 @@ const logger = createLogger() /** * @param {Map} map * @param {string} formId + * @param {boolean} [ignore] - ignore live previews */ -function incrementFormCount(map, formId) { +function incrementFormCount(map, formId, ignore = false) { + if (ignore) { + return + } const current = map.get(formId) ?? 0 map.set(formId, current + 1) } @@ -55,9 +59,12 @@ export async function generateReportTimeline(date) { if (status === FormStatus.Draft) { incrementFormCount(timelineMapDraft, submission.meta.formId) } else { - if (!isPreview) { - incrementFormCount(timelineMapLive, submission.meta.formId) - } + const isLivePreview = isPreview + incrementFormCount( + timelineMapLive, + submission.meta.formId, + isLivePreview + ) } }