From 1b6f9c3fc813fc4932f8beb09327a0ef8d95bee7 Mon Sep 17 00:00:00 2001 From: matt Date: Fri, 19 Apr 2024 13:21:01 +0100 Subject: [PATCH 1/2] add test for govuk formatted blockquotes --- .gitignore | 1 + spec/govuk_markdown_spec.rb | 29 +++++++++++++++++++++++++---- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index f6216f2..4b6bd36 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,6 @@ /.bundle/ /.yardoc +/.idea/ /_yardoc/ /coverage/ /doc/ diff --git a/spec/govuk_markdown_spec.rb b/spec/govuk_markdown_spec.rb index af6fd54..07d6a39 100644 --- a/spec/govuk_markdown_spec.rb +++ b/spec/govuk_markdown_spec.rb @@ -123,10 +123,31 @@ ) end - it "renders links with titles with GOV.UK classes" do - expect(render('[GOV.UK homepage](https://www.gov.uk "My title")')).to eq( - '

GOV.UK homepage

', - ) + it "renders blockquotes with GOV.UK classes" do + input = <<~MARKDOWN + > You quoted me! + MARKDOWN + expected = <<~HTML +
+

You quoted me!

+
+ HTML + expect(render(input)).to eq(expected.strip) + end + + it "renders blockquotes with multiple paragraphs and GOV.UK classes" do + input = <<~MARKDOWN + > You quoted me once, + > + > you should do it again! + MARKDOWN + expected = <<~HTML +
+

You quoted me once,

+

you should do it again!

+
+ HTML + expect(render(input)).to eq(expected.strip) end it "renders hrules with GOV.UK classes" do From 505127f90fd0301b60dd388d9232418168d19a92 Mon Sep 17 00:00:00 2001 From: matt Date: Fri, 19 Apr 2024 13:30:52 +0100 Subject: [PATCH 2/2] handle correct govuk markup for blockquotes --- lib/govuk_markdown/renderer.rb | 8 ++++++++ spec/govuk_markdown_spec.rb | 6 +++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/lib/govuk_markdown/renderer.rb b/lib/govuk_markdown/renderer.rb index 223df9e..dcc0710 100644 --- a/lib/govuk_markdown/renderer.rb +++ b/lib/govuk_markdown/renderer.rb @@ -88,6 +88,14 @@ def hrule HTML end + def block_quote(content) + <<~HTML +
+ #{content.strip} +
+ HTML + end + def preprocess(document) Preprocessor .new(document) diff --git a/spec/govuk_markdown_spec.rb b/spec/govuk_markdown_spec.rb index 07d6a39..0ba30e1 100644 --- a/spec/govuk_markdown_spec.rb +++ b/spec/govuk_markdown_spec.rb @@ -129,7 +129,7 @@ MARKDOWN expected = <<~HTML
-

You quoted me!

+

You quoted me!

HTML expect(render(input)).to eq(expected.strip) @@ -143,8 +143,8 @@ MARKDOWN expected = <<~HTML
-

You quoted me once,

-

you should do it again!

+

You quoted me once,

+

you should do it again!

HTML expect(render(input)).to eq(expected.strip)