remove boolean arg from fixImpassible and setOwnableBuilding and doc improvements

Author: warmist

docs/dev/Lua API.rst

@@ -6071,29 +6071,30 @@ building-hacks
 
 This plugin extends DF workshops to support custom powered buildings.
 
+.. note:: when using numeric ids for workshops be aware that those id can change between worlds
+
 .. contents::
   :local:
 
 Functions
 ---------
 
-* ``setOwnableBuilding(workshop_type, enable)``
+* ``setOwnableBuilding(workshop_type)``
 
   Set workshop to be included in zones (such as bedroom or inn).
 
   :workshop_type:   custom workshop string id e.g. ``SOAPMAKER`` or numeric id
-  :enable:   boolean value to enable or disable this functionality
 
-* ``fixImpassible(workshop_type, enable)``
+* ``fixImpassible(workshop_type)``
 
   Set workshop non walkable tiles to also block liquids (i.e. water and magma).
 
   :workshop_type:   custom workshop string id e.g. ``SOAPMAKER`` or numeric id
-  :enable:   boolean value to enable or disable this functionality
 
 * ``setMachineInfo(workshop_type, needs_power, power_consumed, power_produced, connection_points)``
 
-  Setup and enable machine-like functionality for the workshop. Note: due to implementation limitations
+  Setup and enable machine-like functionality for the workshop. All workshops of this type will have
+  this as default power consumption/production. Note: due to implementation limitations
   workshop only connects to other machines if the other machine is build later than this one.
 
   :workshop_type:   custom workshop string id e.g. ``SOAPMAKER`` or numeric id
@@ -6140,17 +6141,18 @@ Functions
 
   :name:   custom workshop string id e.g. ``SOAPMAKER``
   :interval:   how many ticks to skip between event triggers
-  :callback:   function to call
+  :callback:   function to call. Function signature is ``func(workshop)`` where ``workshop`` is of type
+               ``df.building_workshopst``
 
 * ``getPower(building)``
 
   Returns two number - produced and consumed power if building can be modified and returns nothing otherwise.
 
   :building:   specific workshop that produces or consumes power
 
-* ``setPower(building,power_consumed, power_produced)``
+* ``setPower(building, power_consumed, power_produced)``
 
-  Sets current power production and consumption for a building. Can be used to make buildings that
+  Sets current power production and consumption for a specific workshop building. Can be used to make buildings that
   dynamically change power consumption and production.
 
   :building:   specific workshop that produces or consumes power

plugins/building-hacks.cpp

@@ -461,14 +461,13 @@ static void loadFrames(lua_State* L,workshop_hack_data& def,int stack_pos)
     return ;
 }
 
-//fixImpassible(workshop_type,bool) - changes how impassible tiles work with liquids. False - default behaviour. True - blocks liquids.
+//fixImpassible(workshop_type) - changes how impassible tiles work with liquids.
 static int fixImpassible(lua_State* L)
 {
     int workshop_type = get_workshop_type(L, 1);
-    bool impassible_setting = lua_toboolean(L, 2);
 
     auto& def = hacked_workshops[workshop_type];
-    def.impassible_fix = impassible_setting;
+    def.impassible_fix = true;
 
     enable_hooks(true);
 
@@ -541,14 +540,13 @@ static int setAnimationInfo(lua_State* L)
 
     return 0;
 }
-//setOwnableBuilding(workshop_type,bool is_ownable)
+//setOwnableBuilding(workshop_type)
 static int setOwnableBuilding(lua_State* L)
 {
     int workshop_type = get_workshop_type(L, 1);
-    bool room_subset = lua_toboolean(L, 2);
 
     auto& def = hacked_workshops[workshop_type];
-    def.room_subset = room_subset;
+    def.room_subset = true;
 
     enable_hooks(true);