Upgrade Doctrine/orm to 3.x and DBAL to 4.x

Author: nickygerritsen

webapp/composer.json

@@ -57,7 +57,7 @@
 		"doctrine/doctrine-bundle": "^2.8",
 		"doctrine/doctrine-fixtures-bundle": "^4.0",
 		"doctrine/doctrine-migrations-bundle": "^3.2",
-		"doctrine/orm": "^2.14",
+		"doctrine/orm": "^3.0",
 		"enshrined/svg-sanitize": "^0.22.0",
 		"friendsofsymfony/rest-bundle": "^3.5",
 		"ircmaxell/password-compat": "*",

webapp/composer.lock

@@ -17,7 +17,7 @@ doctrine:
             internal_error_status: App\Doctrine\DBAL\Types\InternalErrorStatusType
             judge_task_type: App\Doctrine\DBAL\Types\JudgeTaskType
         mapping_types:
-            enum: string
+            enum: enum
         schema_filter: ~^(?!sessions)~
         # IMPORTANT: You MUST configure your server version,
         # either here or in the DATABASE_URL env var (see .env file)
@@ -31,6 +31,7 @@ doctrine:
         controller_resolver:
             auto_mapping: false
         enable_lazy_ghost_objects: true
+        enable_native_lazy_objects: true
         mappings:
             App:
                 type: attribute

webapp/config/packages/doctrine.yaml

@@ -24,6 +24,9 @@ framework:
     assets:
         version: "v=%domjudge.version%"
 
+    property_info:
+        with_constructor_extractor: true
+
 when@test:
     framework:
         test: true

webapp/config/packages/framework.yaml

@@ -8,4 +8,3 @@ services:
     #Twig\Extensions\ArrayExtension: ~
     #Twig\Extensions\DateExtension: ~
     #Twig\Extensions\IntlExtension: ~
-    Twig\Extensions\TextExtension: ~

webapp/config/packages/twig_extensions.yaml

@@ -14,4 +14,6 @@ when@test:
         intercept_redirects: false
 
     framework:
-        profiler: { collect: false }
+        profiler:
+            collect: false
+            collect_serializer_data: true

webapp/config/packages/web_profiler.yaml

@@ -180,7 +180,7 @@
  *             options?: array<string, mixed>,
  *             mapping_types?: array<string, scalar|null>,
  *             default_table_options?: array<string, scalar|null>,
- *             schema_manager_factory?: scalar|null, // Default: "doctrine.dbal.legacy_schema_manager_factory"
+ *             schema_manager_factory?: scalar|null, // Default: "doctrine.dbal.default_schema_manager_factory"
  *             result_cache?: scalar|null,
  *             slaves?: array<string, array{ // Default: []
  *                 url?: scalar|null, // A URL with connection information; any parameter value parsed from this string will override explicitly set parameters
@@ -251,7 +251,7 @@
  *     orm?: array{
  *         default_entity_manager?: scalar|null,
  *         auto_generate_proxy_classes?: scalar|null, // Auto generate mode possible values are: "NEVER", "ALWAYS", "FILE_NOT_EXISTS", "EVAL", "FILE_NOT_EXISTS_OR_CHANGED", this option is ignored when the "enable_native_lazy_objects" option is true // Default: false
- *         enable_lazy_ghost_objects?: bool, // Enables the new implementation of proxies based on lazy ghosts instead of using the legacy implementation // Default: false
+ *         enable_lazy_ghost_objects?: bool, // Enables the new implementation of proxies based on lazy ghosts instead of using the legacy implementation // Default: true
  *         enable_native_lazy_objects?: bool, // Enables the new native implementation of PHP lazy objects instead of generated proxies // Default: false
  *         proxy_dir?: scalar|null, // Configures the path where generated proxy classes are saved when using non-native lazy objects, this option is ignored when the "enable_native_lazy_objects" option is true // Default: "%kernel.build_dir%/doctrine/orm/Proxies"
  *         proxy_namespace?: scalar|null, // Defines the root namespace for generated proxy classes when using non-native lazy objects, this option is ignored when the "enable_native_lazy_objects" option is true // Default: "Proxies"
@@ -297,7 +297,7 @@
  *             fetch_mode_subselect_batch_size?: scalar|null,
  *             repository_factory?: scalar|null, // Default: "doctrine.orm.container_repository_factory"
  *             schema_ignore_classes?: list<scalar|null>,
- *             report_fields_where_declared?: bool, // Set to "true" to opt-in to the new mapping driver mode that was added in Doctrine ORM 2.16 and will be mandatory in ORM 3.0. See https://github.com/doctrine/orm/pull/10455. // Default: false
+ *             report_fields_where_declared?: bool, // Set to "true" to opt-in to the new mapping driver mode that was added in Doctrine ORM 2.16 and will be mandatory in ORM 3.0. See https://github.com/doctrine/orm/pull/10455. // Default: true
  *             validate_xml_mapping?: bool, // Set to "true" to opt-in to the new mapping driver mode that was added in Doctrine ORM 2.14. See https://github.com/doctrine/orm/pull/6728. // Default: false
  *             second_level_cache?: array{
  *                 region_cache_driver?: string|array{

webapp/config/reference.php

@@ -1,4 +1,4 @@
 when@dev:
     _errors:
-        resource: '@FrameworkBundle/Resources/config/routing/errors.xml'
+        resource: '@FrameworkBundle/Resources/config/routing/errors.php'
         prefix: /_error

webapp/config/routes/framework.yaml

@@ -1,8 +1,8 @@
 when@dev:
     web_profiler_wdt:
-        resource: '@WebProfilerBundle/Resources/config/routing/wdt.xml'
+        resource: '@WebProfilerBundle/Resources/config/routing/wdt.php'
         prefix: /_wdt
 
     web_profiler_profiler:
-        resource: '@WebProfilerBundle/Resources/config/routing/profiler.xml'
+        resource: '@WebProfilerBundle/Resources/config/routing/profiler.php'
         prefix: /_profiler

webapp/config/routes/web_profiler.yaml

@@ -20,7 +20,7 @@ public function getDescription(): string
     public function up(Schema $schema): void
     {
         $this->skipIf(
-            $this->connection->getSchemaManager()->tablesExist(['contest']),
+            $this->connection->createSchemaManager()->tablesExist(['contest']),
             'table contest already exists'
         );