Skip to content

Commit d4e80ec

Browse files
committed
Revert "Allow alpha channel in Hex/RGB conversions"
This reverts commit 9afb95b.
1 parent a20a84f commit d4e80ec

File tree

1 file changed

+6
-54
lines changed

1 file changed

+6
-54
lines changed

webapp/tests/Unit/Utils/UtilsTest.php

Lines changed: 6 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,6 @@ public function testConvertToHexConvert(): void
320320
self::assertEquals('#AABBCC', Utils::convertToHex('#aabbcc'));
321321
self::assertEquals('#AAABBBCCC', Utils::convertToHex('#aaabbbccc'));
322322
self::assertEquals('#DEF', Utils::convertToHex('#def'));
323-
self::assertEquals('#AABBCCDD', Utils::convertToHex('#aabbccdd'));
324323
}
325324

326325
public function testParseHexColor(): void
@@ -330,14 +329,6 @@ public function testParseHexColor(): void
330329
self::assertEquals([0, 0, 0], Utils::parseHexColor('#000'));
331330
self::assertEquals([171, 205, 239], Utils::parseHexColor('#abcdef'));
332331
self::assertEquals([254, 220, 186], Utils::parseHexColor('#FEDCBA'));
333-
self::assertEquals([255, 255, 255, 255], Utils::parseHexColor('#ffffff'));
334-
self::assertEquals([0, 0, 0, 255], Utils::parseHexColor('#000000'));
335-
self::assertEquals([0, 0, 0, 255], Utils::parseHexColor('#000'));
336-
self::assertEquals([0, 0, 0, 0], Utils::parseHexColor('#00000000'));
337-
self::assertEquals([0, 0, 0, 0], Utils::parseHexColor('#0000'));
338-
self::assertEquals([171, 205, 239, 255], Utils::parseHexColor('#abcdef'));
339-
self::assertEquals([254, 220, 186, 255], Utils::parseHexColor('#FEDCBA'));
340-
self::assertEquals([254, 220, 186, 0], Utils::parseHexColor('#FEDCBA00'));
341332
}
342333

343334
public function testComponentToHex(): void
@@ -350,44 +341,10 @@ public function testComponentToHex(): void
350341

351342
public function testRgbToHex(): void
352343
{
353-
self::assertEquals('#ffffffff', Utils::rgbToHex([255, 255, 255, 255]));
354-
self::assertEquals('#ffffff00', Utils::rgbToHex([255, 255, 255, 0]));
355-
self::assertEquals('#000000ff', Utils::rgbToHex([0, 0, 0, 255]));
356-
self::assertEquals('#00000000', Utils::rgbToHex([0, 0, 0, 0]));
357-
self::assertEquals('#abcdefff', Utils::rgbToHex([171, 205, 239, 255]));
358-
self::assertEquals('#fedcbaff', Utils::rgbToHex([254, 220, 186, 255]));
359-
}
360-
361-
public function testRelativeLuminance(): void
362-
{
363-
self::assertEquals(0.0, Utils::relativeLuminance("#000000"));
364-
self::assertEquals(1.0, Utils::relativeLuminance("#FFFfff"));
365-
self::assertEquals(1.0, Utils::relativeLuminance("#FFFfffFF"));
366-
self::assertEquals(0.00751604342389449, Utils::relativeLuminance("#123"));
367-
self::assertEquals(0.528186803960141, Utils::relativeLuminance("#1234"));
368-
}
369-
370-
/**
371-
* Test that the APCA contrast function returns the correct data
372-
*/
373-
public function testApcaContrast(): void
374-
{
375-
self::assertEquals(-114.0, Utils::apcaContrast("#ffffff", "#000000"));
376-
self::assertEquals(114.0, Utils::apcaContrast("#000000", "#ffffff"));
377-
self::assertEquals(0.0, Utils::apcaContrast("#fffFFF", "#FFFfff"));
378-
self::assertEquals(-0.36, Utils::apcaContrast("#111", "#111"));
379-
self::assertEquals(58.09, Utils::apcaContrast("#123f", "#975A"));
380-
self::assertEquals(25.15, Utils::apcaContrast("#11223344", "#00110011"));
381-
self::assertEquals(-35.06, Utils::apcaContrast("#11223344", "#FF0011"));
382-
}
383-
384-
public function testHexToForegroundAndBorder(): void
385-
{
386-
self::assertEquals(["#000000", "#bfbd9dff"], Utils::hexToForegroundAndBorder("#fffDDD"));
387-
self::assertEquals(["#ffffff", "#000000ff"], Utils::hexToForegroundAndBorder("#000000"));
388-
self::assertEquals(["#000000", "#6a7b8cff"], Utils::hexToForegroundAndBorder("#ABC"));
389-
self::assertEquals(["#ffffff", "#00000099"], Utils::hexToForegroundAndBorder("#1239"));
390-
self::assertEquals(["#000000", "#00000040"], Utils::hexToForegroundAndBorder("#10203040"));
344+
self::assertEquals('#ffffff', Utils::rgbToHex([255, 255, 255]));
345+
self::assertEquals('#000000', Utils::rgbToHex([0, 0, 0]));
346+
self::assertEquals('#abcdef', Utils::rgbToHex([171, 205, 239]));
347+
self::assertEquals('#fedcba', Utils::rgbToHex([254, 220, 186]));
391348
}
392349

393350
public function testRelativeLuminance(): void
@@ -425,15 +382,10 @@ public function testHexToForegroundAndBorder(): void
425382
public function testConvertToHexUnknown(): void
426383
{
427384
self::assertNull(Utils::convertToHex('doesnotexist'));
428-
<<<<<<< HEAD
429385
self::assertNull(Utils::convertToHex('#aabbccdd'));
430386
self::assertNull(Utils::convertToHex('#12345h'));
431387
self::assertNull(Utils::convertToHex('#1234'));
432388
self::assertNull(Utils::convertToHex('#12'));
433-
=======
434-
self::assertNull(Utils::convertToHex('#aabbccddee'));
435-
self::assertNull(Utils::convertToHex('#12346h'));
436-
>>>>>>> 8a732fda2 (Allow alpha channel in Hex/RGB conversions)
437389
}
438390

439391
/**
@@ -852,7 +804,7 @@ public function testSanitizeSvg(): void
852804
<a xlink:href="javascript:alert(2)">test 2</a>
853805
<a href="#test3">test 3</a>
854806
<a xlink:href="#test">test 4</a>
855-
807+
856808
<a href="data:data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' onload='alert(88)'%3E%3C/svg%3E">test 5</a>
857809
<a xlink:href="data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' onload='alert(88)'%3E%3C/svg%3E">test 6</a>
858810
<use xlink:href="defs.svg#icon-1"/>
@@ -865,7 +817,7 @@ public function testSanitizeSvg(): void
865817
<this>shouldn't be here</this>
866818
<script>alert(1);</script>
867819
<line fill="none" stroke="#000000" stroke-miterlimit="10" x1="541.54" y1="299.573" x2="543.179" y2="536.458"/>
868-
820+
869821
</svg>
870822
EOF;
871823
$clean = Utils::sanitizeSvg($dirty);

0 commit comments

Comments
 (0)