Symfony 7.4 upgrade #3240
Symfony 7.4 upgrade #3240
Conversation
nickygerritsen
force-pushed
the
symfony-7.4
branch
2 times, most recently
from
9ebfa38 to
8479fcd
Compare
nickygerritsen
changed the title
nickygerritsen
force-pushed
the
symfony-7.4
branch
3 times, most recently
from
9ec2280 to
3cbf43e
Compare
.github/jobs/composer_setup.sh
Outdated
| PHPVERSION=$(php -r 'echo PHP_MAJOR_VERSION.".".PHP_MINOR_VERSION."\n";') | ||
| export PHPVERSION | ||
| echo "$PHPVERSION" | tee -a "$ARTIFACTS"/phpversion.txt | ||
| sudo apt-get -y remove "php$PHPVERSION-redis" |
…ible with symfony/cache anymore Since we don't use or need Redis, this is fine
nickygerritsen
force-pushed
the
symfony-7.4
branch
from
3c8992b to
3fe9239
Compare
| PHPVERSION=$(php -r 'echo PHP_MAJOR_VERSION.".".PHP_MINOR_VERSION."\n";') | ||
| export PHPVERSION | ||
| echo "$PHPVERSION" | tee -a "$ARTIFACTS"/phpversion.txt | ||
| sudo apt-get -y purge "php$PHPVERSION-redis" |
There was a problem hiding this comment.
add a comment why this is required
| -name "bundles" -prune -o \ | ||
| -name "cache" -type d -prune -o \ | ||
| -name "ace" -type d -prune -o \ | ||
| -path "./webapp/config/reference.php" -prune -o \ |
There was a problem hiding this comment.
What is this and why are we doing this?
There was a problem hiding this comment.
See https://symfony.com/blog/new-in-symfony-7-4-better-php-configuration, it is an auto generated file for PHPstan/IDE basically to get code completion in the new format Symfony is moving towards (but we can't use yet). It will be generated everytime and they strongly advice to NOT put it in gitignore.
| - migrations | ||
| - tests | ||
| excludePaths: | ||
| - src/Utils/Adminer.php |
There was a problem hiding this comment.
I will add a comment in the new place, but basically PHPStan got very angry with how we did it before since it can't load adminer.
| if ($numCases > 0) { | ||
| $messages['info'][] = sprintf("Added/updated %d %s testcase(s): {%s}.{in,ans}", | ||
| $numCases, $type, join(',', $testcaseNames)); | ||
| $numCases, $type, implode(',', $testcaseNames)); |
There was a problem hiding this comment.
join is the much better name for the function, is it going away?
There was a problem hiding this comment.
https://www.php.net/join not really, will remove this rule.
| export version="$1" | ||
| db=${2:-install} | ||
| phpversion="${3:-8.1}" | ||
| phpversion="${3:-8.2}" |
There was a problem hiding this comment.
Perhaps move this commit (and I think there were other similar changes in other commits) to a separate PR?
| { | ||
| public function process(ContainerBuilder $container): void | ||
| { | ||
| if (PHP_VERSION_ID < 80400) { |
3 participants
No description provided.