Use external ID in UI everywhere instead of internal database ID #3263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal IDs Part of DOMjudge#3024
Part of DOMjudge#3024 # Conflicts: # webapp/templates/jury/partials/submission_diff.html.twig # webapp/templates/jury/submission_source.html.twig
…nstead of internal IDs Part of DOMjudge#3024
Part of DOMjudge#3024 � Conflicts: � judge/judgedaemon.main.php
meisterT
reviewed
Dec 1, 2025
| private function judgingDirectory(string $workdirpath, array $judgeTask): string | ||
| { | ||
| if (filter_var($judgeTask['submitid'], FILTER_VALIDATE_INT) === false || | ||
| if (filter_var($judgeTask['submitid'], FILTER_VALIDATE_REGEXP, ['options' => ['regexp' => '/^[a-zA-Z0-9_.-]+$/']]) === false || |
Member
There was a problem hiding this comment.
should we define this somewhere more generally?
Member
There was a problem hiding this comment.
Also, what do submission URLs look like after this change?
| $this->addSql('ALTER TABLE version ADD langid_str VARCHAR(32) DEFAULT NULL AFTER langid'); | ||
|
|
||
| $this->addSql("UPDATE language SET langid_str = CASE externalid | ||
| WHEN 'ada' THEN 'adb' |
Member
There was a problem hiding this comment.
huh, ada -> adb? Is that what you want?
| $data['subjectlink'] = $this->generateUrl('jury_problem', ['probId' => $clar->getProblem()->getExternalid()]); | ||
| } elseif ($clar->getCategory()) { | ||
| $concernssubject = $contest->getCid() . "-" . $clar->getCategory(); | ||
| $concernssubject = $contest->getExternalid() . "#" . $clar->getCategory(); |
|
|
||
| #[IsGranted('ROLE_ADMIN')] | ||
| #[Route(path: '/delete-multiple', name: 'jury_team_affiliation_delete_multiple', methods: ['GET', 'POST'])] | ||
| #[Route(path: '/delete-multiple', name: 'jury_team_affiliation_delete_multiple', methods: ['GET', 'POST'], priority: 1)] |
Member
There was a problem hiding this comment.
what does priority: 1 mean/do here?
| * | ||
| * @return array{previous: string|int|null, next: string|int|null} | ||
| */ | ||
| protected function getPreviousAndNextObjectIds( |
Member
There was a problem hiding this comment.
Is it easy to add a few unit tests for this method?
| <tbody> | ||
| {% for p in problems %} | ||
| {% set id=p.probid %} | ||
| {% set id=p.externalId %} |
Member
There was a problem hiding this comment.
looking at all these places, should we just use p.id or p.probid to mean the external id and p.internalId to mean the probid? Could be done separately though
Member
There was a problem hiding this comment.
This might deserve a changelog entry :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3024