Skip to content

Conversation

@vmcj
Copy link
Member

@vmcj vmcj commented Dec 1, 2025

@vmcj vmcj requested a review from nickygerritsen December 1, 2025 09:13
@eldering
Copy link
Member

eldering commented Dec 1, 2025

Based on https://domjudge.sentry.io/issues/7076103482/?project=4510437648695296&query=is%3Aunresolved&referrer=issue-stream

It would be better to (also) include the error log explicitly in the commit message. That way you don't need to log in to sentry to understand why this was needed, but also, it will be retained in our git history, even if the logs are not available in sentry anymore for whatever reason.

@vmcj
Copy link
Member Author

vmcj commented Dec 1, 2025

Based on https://domjudge.sentry.io/issues/7076103482/?project=4510437648695296&query=is%3Aunresolved&referrer=issue-stream

It would be better to (also) include the error log explicitly in the commit message. That way you don't need to log in to sentry to understand why this was needed, but also, it will be retained in our git history, even if the logs are not available in sentry anymore for whatever reason.

I think there is nothing relevant in that issue to explain why we need this. Either this fix shouldn't be needed as we have for every submission a judgement, or this fix is trivial enough. Sentry only warned us it happened in practice, not really why it happened for this specific case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants